[icedtea-web] RFC: do not add unneeded files to netx.jar

Omair Majid omajid at redhat.com
Fri Feb 25 15:18:19 PST 2011


On 02/25/2011 04:52 PM, Dr Andrew John Hughes wrote:
> On 16:31 Fri 25 Feb     , Omair Majid wrote:
>> Hi,
>>
>> The attached patch remove the addition of unrequired files to netx.jar.
>> Currently a number of uneeded files (html files, man pages) are added to
>> netx.jar.
>>
>> The diff in the file list for netx.jar with the patch applied looks like
>> this:
>>
>>    net/sourceforge/jnlp/runtime/JNLPProxySelector.class
>>    net/sourceforge/jnlp/DefaultLaunchHandler.class
>>    net/sourceforge/jnlp/StreamEater.class
>> -net/sourceforge/jnlp/cache/package.html
>> -net/sourceforge/jnlp/event/package.html
>> -net/sourceforge/jnlp/services/package.html
>> -net/sourceforge/jnlp/package.html
>> -net/sourceforge/jnlp/runtime/package.html
>> -javaws.1
>>
>> As you can seen, only html files and the man page is removed. Okay to
>> commit?
>>
>
> Looks fine.  That code dates back to when we used the OpenJDK import mechanism.
> If they weren't in classes.jar then, they wouldn't have been used.
>

Ah, that explains a lot. Thanks for looking over the patch. I have 
pushed it to HEAD.

Cheers,
Omair



More information about the distro-pkg-dev mailing list