[RFC][Icedtea-Web]: Hide unused components in itw-settings.

[Deepak Bhole]

* Andrew Su <asu at redhat.com> [2011-02-27 22:47]:
> Hello,
> 
>  The attached patch will hide the unused components in itw-settings.
>  Unused:
>    Setting cache size.
>    Selecting another JRE for plugin to bind to.
> 
> 
> Questions? Comments? Concerns?
> 
> Cheers,
>   Andrew


Indentations are off. In the interest of keeping it looking clean, can you
please fix it so that the // are right beside the code, and aligned? e.g.


> -                new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),
> +                //                new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),

to

> -                new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),
> +                // new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),

Also, please add a comment in the code stating why it is disabled, so that it
is not forgotten in the future.

Cheers,
Deepak

> diff -r 02ef9ba4d8a2 netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java	Fri Feb 25 18:16:48 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java	Sun Feb 27 21:44:06 2011 -0500
> @@ -225,7 +225,7 @@
>                  new SettingsPanel(Translator.R("CPTabDebugging"), createDebugSettingsPanel()),
>                  new SettingsPanel(Translator.R("CPTabDesktopIntegration"), createDesktopSettingsPanel()),
>                  new SettingsPanel(Translator.R("CPTabNetwork"), createNetworkSettingsPanel()),
> -                new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),
> +                //                new SettingsPanel(Translator.R("CPTabRuntimes"), createRuntimesSettingsPanel()),
>                  new SettingsPanel(Translator.R("CPTabSecurity"), createSecuritySettingsPanel()), };
>  
>          // Add panels.
> diff -r 02ef9ba4d8a2 netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java	Fri Feb 25 18:16:48 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java	Sun Feb 27 21:44:06 2011 -0500
> @@ -152,15 +152,15 @@
>          });
>  
>          // This is to work with how much space is available for caching.
> -        JLabel lCacheSize = new JLabel(Translator.R("TIFPCacheSize") + ":");
> -        slCacheSize = new JSlider(minSize, maxSize, Integer.parseInt(this.config.getProperty(properties[2])));
> -        slCacheSize.setMinorTickSpacing(50);
> -        slCacheSize.setPaintTicks(true);
> -        SpinnerNumberModel snmCacheSize = new SpinnerNumberModel(Integer.parseInt(this.config.getProperty(properties[2])), minSize, maxSize, 1);
> -        spCacheSize = new JSpinner(snmCacheSize);
> -
> -        slCacheSize.addChangeListener(this);
> -        spCacheSize.addChangeListener(this);
> +//        JLabel lCacheSize = new JLabel(Translator.R("TIFPCacheSize") + ":");
> +//        slCacheSize = new JSlider(minSize, maxSize, Integer.parseInt(this.config.getProperty(properties[2])));
> +//        slCacheSize.setMinorTickSpacing(50);
> +//        slCacheSize.setPaintTicks(true);
> +//        SpinnerNumberModel snmCacheSize = new SpinnerNumberModel(Integer.parseInt(this.config.getProperty(properties[2])), minSize, maxSize, 1);
> +//        spCacheSize = new JSpinner(snmCacheSize);
> +//
> +//        slCacheSize.addChangeListener(this);
> +//        spCacheSize.addChangeListener(this);
>  
>          c.gridy = 0;
>          c.gridx = 0;
> @@ -169,16 +169,16 @@
>          c.gridx = 1;
>          c.weightx = 0;
>          diskSpacePanel.add(cbCompression, c);
> -        c.gridy = 1;
> -        c.gridx = 0;
> -        c.gridwidth = GridBagConstraints.REMAINDER;
> +//        c.gridy = 1;
> +//        c.gridx = 0;
> +//        c.gridwidth = GridBagConstraints.REMAINDER;
>          c.weightx = 1;
> -        diskSpacePanel.add(lCacheSize, c);
> -        c.gridwidth = 1;
> -        c.gridy = 2;
> -        diskSpacePanel.add(slCacheSize, c);
> -        c.gridx = 1;
> -        diskSpacePanel.add(spCacheSize, c);
> +//        diskSpacePanel.add(lCacheSize, c);
> +//        c.gridwidth = 1;
> +//        c.gridy = 2;
> +//        diskSpacePanel.add(slCacheSize, c);
> +//        c.gridx = 1;
> +//        diskSpacePanel.add(spCacheSize, c);
>  
>          JPanel buttonDeleteRestore = new JPanel(new FlowLayout(FlowLayout.TRAILING));
>          JButton bViewFiles = new JButton(Translator.R("TIFPViewFiles"));