[icedtea-web] RFC: small cleanup in ControlPanel
Omair Majid
omajid at redhat.com
Tue Jan 4 10:35:28 PST 2011
On 12/17/2010 04:49 PM, Omair Majid wrote:
> Hi,
>
> The attached patch cleans up some code in the ControlPanel, and in the
> process removes dependencies on JNLPRuntime.
>
> ChangeLog:
> 2010-12-17 Omair Majid <omajid at redhat.com>
>
> * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java: Remove
> JNLPRuntime import. Remove configBrowserCommand.
> (SettingsPanel.toString): Add Override annotation.
> (createMainSettingsPanel): Remove call to loadConfiguration.
> (loadConfiguration): Remove method. Setting the browser command
> should be handled by the appropriate panel.
> (main): Remove call to JNLPRuntime.initialize and just create a new
> DeploymentConfiguration object. Clarify TODO comment.
>
Any comments? Ok to commit?
Cheers,
Omair
More information about the distro-pkg-dev
mailing list