Review request: Version tag was cause of failed rpm build of visualvm 1.3.2

[Dr Andrew John Hughes]

On 14:54 Thu 06 Jan     , Pavel Tisnovsky wrote:
> Jiri Vanek wrote:
> > # HG changeset patch
> > # User Jiri Vanek <jvanek at redhat.com>
> > # Date 1294319582 -3600
> > # Node ID df40da40c697d8d5cb3513bf9f9559d02279f346
> > # Parent  ba2ccec163d04ec94ac31ee75cad10d1b7d8f6ee
> > f14 refused Version 1.1pre for 1.3.1 rpm build. Removed Version tag from
> > dektop file
> > 
> > diff -r ba2ccec163d0 -r df40da40c697 visualvm.desktop.in
> > --- a/visualvm.desktop.in    Thu Oct 14 22:40:23 2010 +0100
> > +++ b/visualvm.desktop.in    Thu Jan 06 14:13:02 2011 +0100
> > @@ -6,4 +6,3 @@
> >  Terminal=false
> >  Type=Application
> >  Categories=Development;Java;
> > -Version=@PACKAGE_VERSION@
> 
> Hi Jiri,
> 
> looks ok for me.
> 
> Pavel

Why have you approved this?  A ChangeLog wasn't even given, let alone an explanation of what this patch is meant to do.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8