[icedtea-web] RFC: add missing generic type in JNLPFile

[Dr Andrew John Hughes]

On 11:40 Tue 11 Jan     , Omair Majid wrote:
> Hi,
> 
> The attached patch adds a generic type to 'info' in JNLPFile.
> 
> Ok to commit?
> 
> ChangeLog:
> 2011-01-11  Omair Majid  <omajid at redhat.com>
> 
>      * netx/net/sourceforge/jnlp/JNLPFile: Add missing generic type to
>      info.
>      (getInformation): Remove redundant cast.
> 
> 
> Cheers,
> Omair

Looks good.  javac clearly misses these; is this with ecj?

> diff -r dc02a605f905 netx/net/sourceforge/jnlp/JNLPFile.java
> --- a/netx/net/sourceforge/jnlp/JNLPFile.java	Fri Jan 07 08:00:08 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/JNLPFile.java	Tue Jan 11 11:31:28 2011 -0500
> @@ -80,7 +80,7 @@
>      protected Version specVersion;
>  
>      /** information */
> -    protected List info;
> +    protected List<InformationDesc> info;
>  
>      protected UpdateDesc update;
>  
> @@ -326,7 +326,7 @@
>                  List<Object> result = new ArrayList<Object>();
>  
>                  for (int i = 0; i < info.size(); i++) {
> -                    InformationDesc infoDesc = (InformationDesc) info.get(i);
> +                    InformationDesc infoDesc = info.get(i);
>  
>                      if (localMatches(locale, infoDesc.getLocales()))
>                          if (localMatches(locale, infoDesc.getLocales()))


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8