[RFC][IcedTea-Web]: Add Logging of applet exceptions.

[Andrew Su]

On 01/11/2011 04:00 PM, Dr Andrew John Hughes wrote:
> On 15:39 Tue 11 Jan     , Andrew Su wrote:
>>
>> ----- Original Message -----
>>> From: "Andrew Su"<asu at redhat.com>
>>> To: "OpenJDK"<distro-pkg-dev at openjdk.java.net>
>>> Sent: Tuesday, January 11, 2011 2:19:57 PM
>>> Subject: [RFC][IcedTea-Web]: Add Logging of applet exceptions.
>>> Hello,
>>>
>>> I have attached a patch which allows exceptions be logged to file if
>>> the
>>> option "Enable logging" is set in deployments.property file.
>>>
>>> Comments? Questions? Concerns?
>> Hi,
>>
>> I have updated the patch (removed unused import).
>>
>> Cheers,
>>   Andrew
> As Log and AppletLogger should never have instances (as far as I can tell), you
> should add a private no-argument constructor to prevent them being created.
> Also, it would be nice to break the long line in Log (the getName() one) onto
> two lines.
> Other than that, looks good.
Hi Andrew,

I have made the above changes, but making constructor for Log private 
needs me to make a different constructor for AppletLogger so instead I 
used no modifier for the constructor which is only accessible from the 
same package. (However used private for AppletLogger's constructor.)

Ok for head?

Cheers,
   Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110111_add_logging_v3.patch
Type: text/x-patch
Size: 5461 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110111/17f30895/20110111_add_logging_v3.patch