[RFC][IcedTea-Web]: Add Logging of applet exceptions.

[Dr Andrew John Hughes]

On 10:15 Wed 12 Jan     , Andrew Su wrote:
> 
> --Snip--
> > > >
> > > >> + public static Logger logger;
> > > >> +
> > > >> + static {
> > > >> + try {
> > > >> + // If logging is enabled, we create logger.
> > > >> + if (enableLogging) {
> > > >> + String fn = icedteaLogDir + "Plugin" +
> > > >> java.lang.System.currentTimeMillis() + ".log";
> > > >> + boolean append = false;
> > > >> + FileHandler fh = new FileHandler(fn, append);
> > > >> + fh.setFormatter(new XMLFormatter());
> > > >
> > > > Hmm.. is this line saying that logs should be written in XML?
> > > Yes, this is to follow the format of how the proprietary plugin does
> > > logging. This will keep any tools being used with those logs to
> > > continue
> > > with our plugin's logs.
> > 
> > Is there any real advantage to this? Do you have an example of the
> > output
> > to see how readable it is? I don't think we should do things just
> > because
> > some proprietary vendor's product does.
> 
> Here is an example of how it would look like.
> 
> <?xml version="1.0" encoding="UTF-8" standalone="no"?>
> <!DOCTYPE log SYSTEM "logger.dtd">
> <log>
> <record>
>   <date>2011-01-12T10:14:58</date>
>   <millis>1294845298608</millis>
>   <sequence>0</sequence>
>   <logger>net.sourceforge.jnlp.debug.AppletLog</logger>
>   <level>FINE</level>
>   <class>net.sourceforge.jnlp.debug.AppletLog</class>
>   <method>log</method>
>   <thread>10</thread>
>   <message>java.lang.NullPointerException
> 	at Democritus.init(Democritus.java:25)
> 	at sun.applet.AppletPanel.run(AppletPanel.java:436)
> 	at net.sourceforge.jnlp.NetxPanel.run(NetxPanel.java:69)
> 	at java.lang.Thread.run(Thread.java:636)
> </message>
> </record>
> </log>
> 

I guess it is fairly readable, but it would be different to the proprietary logs
anyway as the classes will be different.

Ok, we'll go with that, unless anyone else objects.

> 
> > 
> > > >
> > > >> + logger =
> > > >> Logger.getLogger(AppletLogger.class.getPackage().getName() + "."
> > > >> +
> > > >> AppletLogger.class.getName());
> > > >> + logger.setLevel(Level.ALL);
> > > >> + logger.addHandler(fh);
> > > >> + }
> > > >> + } catch (IOException e) {
> > > >> + e.printStackTrace();
> > > >> + }
> > > >> + }
> 
> --Snip--
> 
> Regards,
>   Andrew

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8