[RFC][IcedTea-Web]: Removing dead unused commented code

Andrew Su asu at redhat.com
Thu Jan 13 15:19:13 PST 2011


Hello,

This patch is an attempt to remove dead, unused or commented code from the plugin directory in icedtea-web. 

(I have provided the patch for each file separately for easier reading.) 

Some comments though..
 General Note:
    Changed the copyright to be 2011 for all the modified files.

 These are the methods that will be removed with the patch (unused private methods)
    PluginMessageConsumer.java:getReference(String[])
    PluginMessageConsumer.java:isInInit(Integer)
    PluginMessageConsumer.java:dumpWorkerStatus()
    PluginAppletViewer.java:makeReader(InputStream)
    PluginMessageConsumer.java:getReference(String[])
    PluginMessageConsumer.java:isInInit(Integer)
    PluginMessageConsumer.java:dumpWorkerStatus()
 
 In the following method, will we be needing this block of commented out conditions in the future?
    PluginAppletSecurityContext.java:getAccessControlContext(String[], String)


I have tried building it and that succeeds. Tested running some simple applets and those seem to work as well.

Questions comments concerns?

Regards,
  Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff_patch.tar
Type: application/x-tar
Size: 51200 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110113/ed463bdc/diff_patch.tar 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110113_remove_unused_imports_and_private_v2.patch
Type: text/x-patch
Size: 33370 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110113/ed463bdc/20110113_remove_unused_imports_and_private_v2.patch 


More information about the distro-pkg-dev mailing list