Reviewer needed - new regression test for checking font rendering & addition of copyright text to existing test

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 16:27 Mon 17 Jan     , Pavel Tisnovsky wrote:
>> Hi all,
>>
>> I'd like to add new regression test which check proper rendering of
>> international fonts using various logical font names and font styles.
>> This new test is stored in attachment as [InternationalFontsStyles.java]
>> (for review) and it is also part of icedtea-jtreg-international-fonts.patch.
>>
>> I also added copyright text into existing test
>> InternationalFontRendering..java. Both changes are included as hg diff
>> done against recent IcedTea6 [hg_diff].
>>
>> Can anyone please review these changes?
>>
>> Thank you in advance
>> Pavel
> 
> Couple of points:
> 
> * I think the characters used should use the Unicode escape notation (\uXXXX).
> Here in the mail, at least, they are just displaying as ?????.
> * You don't include any change to Makefile.am to actually apply the patch.
> 
> Also for future reference, the ChangeLog should be in the body of the
> e-mail not the patch, when posting to the list, so others can more
> easily apply and test the patch.
> 

Hi Andrew and all,

here are [InternationalFontsStyles.java] updated version of new
regression test I'd like to add to IcedTea6. hg diff containing changes
in icedtea-jtreg-international-fonts.patch is stored in [hg_diff].
Please note that the patch file mentioned above already exists, so no
changes has to be made in Makefile.am.

This version uses escape notation of Unicode (non-ASCII) characters and
I've also changed recent test InternationalFontRendering.java to use
this notation too.

Excerpt from ChangeLog:
2011-01-17  Pavel Tisnovsky  <ptisnovs at redhat.com>

	* patches/icedtea-jtreg-international-fonts.patch:
	Added new font test - InternationalFontsStyles
	Added copyright text into InternationalFontRendering

2011-01-07  Andrew John Hughes  <ahughes at redhat.com>

Could you please review this version?

Thank you in advance
Pavel
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: hg_diff
Url: http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110117/75368ac3/hg_diff.ksh 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: InternationalFontsStyles.java
Type: text/x-java
Size: 11029 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110117/75368ac3/InternationalFontsStyles.java