Request to backport 6736649 and 6797139

[Dr Andrew John Hughes]

On 09:40 Mon 17 Jan     , Omair Majid wrote:
> On 01/17/2011 09:10 AM, Dr Andrew John Hughes wrote:
> > On 17:35 Fri 14 Jan     , Omair Majid wrote:
> >> I would like to backport the following two changesets to openjdk6:
> >>
> >> changeset:   624:e78c2f17a606
> >> user:        mlapshin
> >> date:        Tue Aug 26 12:16:23 2008 +0400
> >> summary:     6736649:
> >> test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on
> >> Linux
> >>
> >> changeset:   1637:281fbd82a971
> >> user:        alexp
> >> date:        Wed Sep 02 17:47:19 2009 +0400
> >> summary:     6797139: JButton title is truncating for some strings
> >> irrespective of preferred size.
> >>
> >> Together, these changesets fix a bug where some strings are incorrectly
> >> being truncated.
> >>
> >
> > I don't see either of these in IcedTea6.  Please add them there first before
> > trying to upstream them.
> >
> 
> I was going to add them to IcedTea6 as soon as Joe approved them for 
> openjdk6. Can I assume you are okay with adding it to IcedTea6 without 
> waiting for Joe's comments?

Post the patch and we can make that decision :-)

> The reason I ping openjdk6 is that they are 
> much more likely to notice things like accidental conflicts with specs.
>

There's no reason the patch can't be upstream concurrently to OpenJDK6,
but the first priority should be to IcedTea6 as that's what gets packaged
in GNU/Linux distributions and consumed by end users.  IME, it's more likely
that issues will be picked up through general IcedTea6 use by developers
and distro usage.

It's nice to get stuff into OpenJDK too, but it takes time, firstly
for it to be approved and then for it to actually be released. b21
still hasn't been released, for example.

> Cheers,
> Omair

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8