[RFC][IcedTea-Web]: Add Logging of applet exceptions.
Andrew Su
asu at redhat.com
Mon Jan 17 10:45:56 PST 2011
On 01/17/2011 01:39 PM, Omair Majid wrote:
> On 01/17/2011 01:32 PM, Andrew Su wrote:
>>> > +
>>> > + static {
>>> > + try {
>>> > + // If logging is enabled, we create logger.
>>> > + if (enableLogging) {
>>> > + String fn = icedteaLogDir + "Plugin" +
>>> > java.lang.System.currentTimeMillis() + ".log";
>>>
>>> If I understand this correctly, every applet creates a new log file.
>> No, static initialization blocks are called only once when loading the
>> class.
>> Unless they kill the plugin then reload another page it will use the
>> same file.
>>
>
> Ok, that's much better than a log file per applet.
>
> Everything else looks good to me. Assuming that you have tested this
> and that there are no objections from anyone else, please go ahead and
> commit the patch.
>
Thanks for looking it over! Pushed to HEAD.
> Thanks,
> Omair
More information about the distro-pkg-dev
mailing list