[RFC][IcedTea-Web]: Moved creation of swing thread.

[Deepak Bhole]

* Andrew Su <asu at redhat.com> [2011-01-18 13:42]:
> 
> 
> ----- Original Message -----
> > From: "Deepak Bhole" <dbhole at redhat.com>
> > To: "Omair Majid" <omajid at redhat.com>
> > Cc: "Andrew Su" <asu at redhat.com>, "distro-pkg-dev" <distro-pkg-dev at openjdk.java.net>
> > Sent: Tuesday, January 18, 2011 1:02:30 PM
> > Subject: Re: [RFC][IcedTea-Web]: Moved creation of swing thread.
> > * Omair Majid <omajid at redhat.com> [2010-12-23 16:07]:
> > > On 12/23/2010 04:04 PM, Andrew Su wrote:
> > > >>>           setSystemLookAndFeel();
> > > >>
> > > >>Can you please remove this? I dont think this is doing anything.
> > > >As said in previous e-mail, this will be in the patch to follow.
> > >
> > > Sorry, I must have missed it.
> > >
> > > >
> > > >Can you look it over again once more, for some of the changes.
> > > >Thanks.
> > > >Ok for head?
> > > >
> > >
> > > Yup. Ok for HEAD.
> > 
> > Okay for 1.0 as well. Would be a nice bugfix to have in stable
> > release.
> Hello,
> 
> The export does not apply cleanly due to other changes from other changesets prior to this one.
> 
> I have attached a patch that will fix the appropriate files.
> 
> Cheer,
>   Andrew
> 

Looks fine. Okay for 1.0.

Cheers,
Deepak

> 
> 
> > 
> > Deepak
> > 
> > >
> > > Cheers,
> > > Omair

> diff -r ee7a2e5e3849 ChangeLog
> --- a/ChangeLog	Tue Jan 18 12:07:45 2011 -0500
> +++ b/ChangeLog	Tue Jan 18 13:41:01 2011 -0500
> @@ -1,3 +1,8 @@
> +2011-01-18  Andrew Su  <asu at redhat.com>
> +
> +	* netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java:
> +	(showAdvancedProxySettingsDialog): Removed creation of swing thread.
> +
>  2011-01-04  Omair Majid  <omajid at redhat.com>
>  
>  	* netx/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> diff -r ee7a2e5e3849 netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java
> --- a/netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java	Tue Jan 18 12:07:45 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java	Tue Jan 18 13:41:01 2011 -0500
> @@ -116,21 +116,13 @@
>       * 
>       * @param config
>       *            A loaded DeploymentConfiguration file.
> -     * @throws Exception
>       */
> -    public static void showAdvancedProxySettingsDialog(final DeploymentConfiguration config) throws Exception {
> -        setSystemLookAndFeel();
> -        SwingUtilities.invokeLater(new Runnable() {
> -            @Override
> -            public void run() {
> -                AdvancedProxySettingsDialog psd = new AdvancedProxySettingsDialog(config);
> -                psd.setResizable(false);
> -                psd.centerDialog();
> -                psd.setVisible(true);
> -                psd.dispose();
> -            }
> -        });
> -
> +    public static void showAdvancedProxySettingsDialog(final DeploymentConfiguration config) {
> +        AdvancedProxySettingsDialog psd = new AdvancedProxySettingsDialog(config);
> +        psd.setResizable(false);
> +        psd.centerDialog();
> +        psd.setVisible(true);
> +        psd.dispose();
>      }
>  
>      /**