[icedtea-web] RFC: exit with error code on failures

[Dr Andrew John Hughes]

On 15:58 Wed 19 Jan     , Omair Majid wrote:
> Hi,
> 
> The attached patch makes netx (and plugin) exit with an error code other 
> than 0 on an error. netx already exits with appropriate error code in 
> some cases (for example, if the input JNLP file is malformed), but not 
> if running the downloaded program fails.
> 
> Before this patch:
> 
> $ javaws jnlp.jnlp
> net.sourceforge.jnlp.LaunchException: Fatal: Launch Error: Could not 
> launch JNLP file.
> (... more output ...)
> $ echo $?
> 0
> 
> After this patch:
> 
> $ javaws jnlp.jnlp
> net.sourceforge.jnlp.LaunchException: Fatal: Launch Error: Could not 
> launch JNLP file.
> (... more output ...)
> $ echo $?
> 1
> 
> Any thoughts or comments?
> 
> Cheers,
> Omair

Sounds good to me.

> diff -r 4e84e06b54e9 netx/net/sourceforge/jnlp/Launcher.java
> --- a/netx/net/sourceforge/jnlp/Launcher.java	Wed Jan 12 12:50:13 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/Launcher.java	Wed Jan 19 15:41:17 2011 -0500
> @@ -834,7 +834,7 @@
>                  exception = ex;
>                  // Exit if we can't launch the application.
>                  if (exitOnFailure)
> -                    System.exit(0);
> +                    System.exit(1);
>              }
>          }
>  
> diff -r 4e84e06b54e9 netx/net/sourceforge/jnlp/NetxPanel.java
> --- a/netx/net/sourceforge/jnlp/NetxPanel.java	Wed Jan 12 12:50:13 2011 -0500
> +++ b/netx/net/sourceforge/jnlp/NetxPanel.java	Wed Jan 19 15:41:17 2011 -0500
> @@ -93,7 +93,7 @@
>                  // Assume user has indicated he does not trust the
>                  // applet.
>                  if (exitOnFailure)
> -                    System.exit(0);
> +                    System.exit(1);
>              }
>              applet = appInst.getApplet();
>  


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8