RFE: Patch for potential browser crash by the plugin

[Dr Andrew John Hughes]

On 17:24 Wed 19 Jan     , Deepak Bhole wrote:
> Hi,
> 
> Attached patch fixes Bug# 619:
> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=619
> 
> ChangeLog:
> 2011-01-19  Deepak Bhole <dbhole at redhat.com>
> 
>    * plugin/icedteanp/java/netscape/javascript/JSObject.java (finalize):
>    Proceed with finalization only if JSObject is valid. 
> 
> 
> Okay for HEAD, 1.0 and backport to maintained icedtea6 branches?
> 
> Cheers,
> Deepak

Assuming you mean IcedTea-Web HEAD, then yes fine for all (including
1.7, 1.8 and 1.9 branches).

Please make sure to document the fix in NEWS.

> diff -r bbbe02c58ddc plugin/icedteanp/java/netscape/javascript/JSObject.java
> --- a/plugin/icedteanp/java/netscape/javascript/JSObject.java	Mon Dec 20 13:37:59 2010 -0500
> +++ b/plugin/icedteanp/java/netscape/javascript/JSObject.java	Wed Dec 22 14:34:58 2010 -0500
> @@ -259,6 +259,11 @@
>       * JavaScript object.
>       */
>      protected void finalize() {
> +
> +        // Proceed if this is a valid object (0L == default long == invalid)
> +        if (internal == 0L)
> +            return;
> +
>          PluginDebug.debug("JSObject.finalize ");
>          PluginAppletViewer.JavaScriptFinalize(internal);
>      }


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8