Reviewer needed - simple changes in regression test InternationalFontsRendering

[Dr Andrew John Hughes]

On 18:00 Tue 18 Jan     , Pavel Tisnovsky wrote:
> Hi all,
> 
> could anybody please review two simple changes in regression test
> InternationalFontsRendering.java which is included in IcedTea6 as patch
> icedtea-jtreg-international-fonts.patch?
> 
> 1st change: added missing copyright info (this test was created by me
> last year hence I used 2010 in (c))
> 2nd change: string which contained UTF-8 characters were translated
> using native2ascii to use Unicode escape notation
> 
> Thank you in advance
> Pavel
> 

Changes look good.  Approved.

> 
> Here is hg diff generated against recent IcedTea6 version:
> 
> 
> diff -r 477489da7897 ChangeLog
> --- a/ChangeLog	Tue Jan 18 16:45:33 2011 +0100
> +++ b/ChangeLog	Tue Jan 18 17:50:18 2011 +0100
> @@ -1,3 +1,10 @@
> +2011-01-18  Pavel Tisnovsky  <ptisnovs at redhat.com>
> +
> +	* patches/icedtea-jtreg-international-fonts.patch:
> +	Added copyright info and translated string originally encoded
> +	in UTF-8 into string using Unicode escape notation in
> +	regression test InternationalFontsRendering.java
> +
>  2011-01-18  Pavel Tisnovsky  <ptisnovs at redhat.com>
> 
>  	* Makefile.am: Apply patch.
> diff -r 477489da7897 patches/icedtea-jtreg-international-fonts.patch
> --- a/patches/icedtea-jtreg-international-fonts.patch	Tue Jan 18
> 16:45:33 2011 +0100
> +++ b/patches/icedtea-jtreg-international-fonts.patch	Tue Jan 18
> 17:50:18 2011 +0100
> @@ -1,6 +1,25 @@
> ---- /dev/null	2010-06-29 14:56:30.329576932 +0200
> -+++
> openjdk/jdk/test/java/awt/font/InternationalFonts/InternationalFontsRendering.java
> 2010-11-01 11:27:46.000000000 +0100
> -@@ -0,0 +1,192 @@
> +--- /dev/null	2010-06-29 11:10:08.737208357 +0200
> ++++
> openjdk/jdk/test/java/awt/font/InternationalFonts/InternationalFontsRendering.java
> 2011-01-17 17:06:44.000000000 +0100
> +@@ -0,0 +1,211 @@
> ++/*
> ++ * Copyright 2010 Red Hat, Inc. All Rights Reserved.
> ++ * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
> ++ *
> ++ * This code is free software; you can redistribute it and/or modify it
> ++ * under the terms of the GNU General Public License version 2 only, as
> ++ * published by the Free Software Foundation.
> ++ *
> ++ * This code is distributed in the hope that it will be useful, but
> WITHOUT
> ++ * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> ++ * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> ++ * version 2 for more details (a copy is included in the LICENSE file that
> ++ * accompanied this code).
> ++ *
> ++ * You should have received a copy of the GNU General Public License
> version
> ++ * 2 along with this work; if not, write to the Free Software Foundation,
> ++ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
> ++ */
> ++
>  +import java.awt.Color;
>  +import java.awt.Font;
>  +import java.awt.Graphics2D;
> @@ -51,13 +70,13 @@
>  +
>  +    private static final String[][] testedStrings = {
>  +        {"Latin-1",    "abcdefABCDEF"},
> -+        {"Latin-2",    "ěščřžýáíéúůľň"},
> -+        {"Cyrilic",    "ДЗИѲФХѰѠЦ"},
> -+        {"Greek",      "βξγδπερζΣσςητθυΩ"},
> -+        {"Asia-Test1", "体中文符号"},
> -+        {"Asia-Test2", "繁體中文符號"},
> -+        {"Asia-Test3", "日本の象徴"},
> -+        {"Asia-Test4", "한국어기호"},
> ++        {"Latin-2",
> "\u011b\u0161\u010d\u0159\u017e\u00fd\u00e1\u00ed\u00e9\u00fa\u016f\u013e\u0148"},
> ++        {"Cyrilic",
> "\u0414\u0417\u0418\u0472\u0424\u0425\u0470\u0460\u0426"},
> ++        {"Greek",
> "\u03b2\u03be\u03b3\u03b4\u03c0\u03b5\u03c1\u03b6\u03a3\u03c3\u03c2\u03b7\u03c4\u03b8\u03c5\u03a9"},
> ++        {"Asia-Test1", "\u4f53\u4e2d\u6587\u7b26\u53f7"},
> ++        {"Asia-Test2", "\u7e41\u9ad4\u4e2d\u6587\u7b26\u865f"},
> ++        {"Asia-Test3", "\u65e5\u672c\u306e\u8c61\u5fb4"},
> ++        {"Asia-Test4", "\ud55c\uad6d\uc5b4\uae30\ud638"},
>  +    };
>  +
>  +    /**

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8