[RFC][IcedTea-Web]: Removing dead unused commented code

[Andrew Su]

----- Original Message -----
> From: "Dr Andrew John Hughes" <ahughes at redhat.com>
> To: "Andrew Su" <asu at redhat.com>, "OpenJDK" <distro-pkg-dev at openjdk.java.net>
> Sent: Thursday, January 20, 2011 10:00:55 AM
> Subject: Re: [RFC][IcedTea-Web]: Removing dead unused commented code
> On 23:31 Thu 13 Jan , Dr Andrew John Hughes wrote:
> > On 18:19 Thu 13 Jan , Andrew Su wrote:
> > > Hello,
> > >
> > > This patch is an attempt to remove dead, unused or commented code
> > > from the plugin directory in icedtea-web.
> > >
> > > (I have provided the patch for each file separately for easier
> > > reading.)
> > >
> > > Some comments though..
> > >  General Note:
> > >     Changed the copyright to be 2011 for all the modified files.
> > >
> >
> > The copyright updates should extend the range, not remove the
> > original.
> > So:
> >
> > > - Copyright (C) 2008 Red Hat
> > > + Copyright (C) 2011 Red Hat
> >
> > becomes
> >
> > - Copyright (C) 2008 Red Hat
> > + Copyright (C) 2008, 2011 Red Hat
> >
> > Also I'm not sure removing code is worth a copyright update.
> >
> > >  These are the methods that will be removed with the patch (unused
> > >  private methods)
> > >     PluginMessageConsumer.java:getReference(String[])
> > >     PluginMessageConsumer.java:isInInit(Integer)
> > >     PluginMessageConsumer.java:dumpWorkerStatus()
> > >     PluginAppletViewer.java:makeReader(InputStream)
> > >     PluginMessageConsumer.java:getReference(String[])
> > >     PluginMessageConsumer.java:isInInit(Integer)
> > >     PluginMessageConsumer.java:dumpWorkerStatus()
> > >
> > >  In the following method, will we be needing this block of
> > >  commented out conditions in the future?
> > >     PluginAppletSecurityContext.java:getAccessControlContext(String[],
> > >     String)
> > >
> > >
> > > I have tried building it and that succeeds. Tested running some
> > > simple applets and those seem to work as well.
> > >
> > > Questions comments concerns?
> > >
> > > Regards,
> > >   Andrew
> >
> >
> 
> The copyright doesn't need updating for these modifications (as they
> only remove code), but the files
> probably do need a general update so that the year of latest
> modification is used. Please do this
> as a separate patch.
> 
> I approve the removal of dead code without the copyright changes.

--snip--

Thanks for looking it over! I have pushed the patch minus the copyright changes.

http://icedtea.classpath.org/hg/icedtea-web/rev/c5b209388b54

Cheers,
  Andrew