[icedtea-web] RFC: add binaries to jre/bin as well (was backport changeset 9397074c2c39 to icedtea-web 1.0)

[Deepak Bhole]

* Dr Andrew John Hughes <ahughes at redhat.com> [2011-01-21 08:37]:
> On 21:19 Thu 20 Jan     , Omair Majid wrote:
> > On 01/20/2011 06:59 PM, Deepak Bhole wrote:
> > > * Omair Majid<omajid at redhat.com>  [2011-01-20 15:57]:
> > >>
> > >> The attached patch hacks the launcher so it simply passes along
> > >> argv[0] to Netx as the system property "java.icedtea-web.bin". Netx
> > >> can then run itself by running the value of this system property.
> > >>
> > >> Can you please look over the patch to see if it makes sense?
> > >>
> > >
> > > I don't think it needs to be that complex (modifying the .c files and
> > > all). Please see the patch I just posted in this thread:
> > >
> > > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2011-January/011814.html
> > >
> > > It is against HEAD and mitigates this issue. If approved, I can push it
> > > into 1.0 after 9397074c2c39, otherwise I will post a subset thereof.
> > >
> > 
> > For 1.0, I agree that the patch I posted may be too complex. But going 
> > forward, when IcedTea-Web becomes installable under /usr/, it may be the 
> > only way of telling javaws how to invoke itself (and still being 
> > relocatable).
> > 
> 
> I agree.  Deepak's changes look like a hack to make the JDK tree
> installation work flexibly but break everything else.  For 1.1, proper
> installation needs to be sorted for the plugin & NetX, and the existing
> version in HEAD works fine for this.
> 

Can you clarify what you mean by 'break everything else'? JRE dir
installation is broken, plain and simple. Even if we were to let that
be, the Launcher.java change has to be made as the JDK is un-relocatable
in its current state. This is a major issue. Something like icedtea-web
should never remove that sort of flexibility.

That said, I do agree, that the solution will need rework for 1.1.

Deepak

> > Cheers,
> > Omair
> 
> -- 
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8