Request to backport 6736649 and 6797139

[Omair Majid]

On 01/18/2011 06:56 PM, Dr Andrew John Hughes wrote:
> On 16:26 Tue 18 Jan     , Omair Majid wrote:
>>>>>>>>> On 17:35 Fri 14 Jan     , Omair Majid wrote:
>>>>>>>>>> I would like to backport the following two changesets to openjdk6:
>>>>>>>>>>
>>>>>>>>>> changeset:   624:e78c2f17a606
>>>>>>>>>> user:        mlapshin
>>>>>>>>>> date:        Tue Aug 26 12:16:23 2008 +0400
>>>>>>>>>> summary:     6736649:
>>>>>>>>>> test/closed/javax/swing/JMenuItem/6458123/ManualBug6458123.java fails on
>>>>>>>>>> Linux
>>>>>>>>>>
>>>>>>>>>> changeset:   1637:281fbd82a971
>>>>>>>>>> user:        alexp
>>>>>>>>>> date:        Wed Sep 02 17:47:19 2009 +0400
>>>>>>>>>> summary:     6797139: JButton title is truncating for some strings
>>>>>>>>>> irrespective of preferred size.
>>>>>>>>>>
>>
>> changeset:   1738:9d78c3d9def2
>> user:        alexp
>> date:        Mon Sep 21 17:58:09 2009 +0400
>> summary:     6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw
>> exceptions when running Java2D demo by clicking Paint ta
>>
>> This changeset gets rid of the StringIndexOutOfBoundsException (by
>> effectively reverting the exception changes).
>>
>
> Ok, so I guess I spotted it quicker than them ;-)
>
> Please backport this one as well.
>

Done. Please see the attached patch.

>>>>> Do the new tests pass?  They should be fixed to use the newer Oracle copyright notices.
>>>>>

Updated the copyright headers.

>>>>
>>>> Sorry, but I forgot to run the tests. I will fix the copyrights, run the
>>>> tests and post the results. I can confirm that the patch does fix the
>>>> issue pointed out in the bug report at
>>>> https://bugzilla.redhat.com/show_bug.cgi?id=661610
>>>>
>>>
>>> This sounds a good reason to backport.
>>>
>>> I'll await the results.
>>
>> I can confirm that the new tests pass. However, I also discovered that
>> swing programs using JMenus crash, so I didnt attempt to run all the tests.
>>
>> I will post an updated patch soon.
>>

And here is the updated patch. I ran the jtreg tests and found no 
related failures. I also ran netbeans using this build and nothing 
seemed broken.

Ok to commit?

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: icedtea6-jbutton-truncation.patch
Type: text/x-patch
Size: 35053 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110124/9a4f0642/icedtea6-jbutton-truncation.patch