[icedtea] Patch for OpenJDK7 b126 support

Dr Andrew John Hughes ahughes at redhat.com
Mon Jan 24 15:33:00 PST 2011


On 22:32 Mon 24 Jan     , Damien Raude-Morvan wrote:
> Hi,
> 
> I've started working on updating icedtea hg to latest b126 drops from OpenJDK.
> You can find my current diff here :
> http://people.debian.org/~drazzib/icedtea-update-b126.patch
> 

Have you actually got it building?  I haven't got the IcedTea forest building
independently yet and the last pull I did was b124.  What are you using to get
b126?

> Is there someone willing to review this work and maybe merge this to icedtea 
> hg repository ?
> As this is my first contribution to Icedtea, feel free to blame me (or point me 
> to the right documentation :)
> 

Few immediate comments from just reading the patch:

* The changesets you move to don't appear to exist on my checkout of the IcedTea
forest.  What are these based on?
* Please don't bump CACAO in the same patch.  This should be done separately
to minimise change.
* Don't change the jaxp/jaxws/jaf URLs.  They are set to use IcedTea as the Oracle
servers have proved unreliable.  I'll update the IcedTea server with these new ones.
This is the first time I've seen them as I've been busy with 6.
* Good catch with the plugin stuff, but again I'd do that in a separate patch.
* The other changes look par for the course.  You seem to be dropping icedtea-ssl.patch
with no explanation though.  Why is this?  It looks like it possibly could be dropped.

Are you doing a full bootstrap with gcj?  I assume so from the ecj patch additions.

> Regards,
> -- 
> Damien

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list