Reviewer needed: patch for regression test jdk/test/java/util/zip/ConstructDeflaterInput.java in IcedTea6 HEAD

[Andrew John Hughes]

On Tue, Jul 12, 2011 at 02:38:40PM +0200, Pavel Tisnovsky wrote:
> Andrew John Hughes wrote:
> > On Tue, Jul 12, 2011 at 01:32:33PM +0200, Pavel Tisnovsky wrote:
> >> Hi,
> >>
> >> I'd like to push patch containing fix for regression test
> >> jdk/test/java/util/zip/ConstructDeflaterInput.java.
> >>
> >> This test sometimes asynchronously prints messages into JTreg log files
> >> which causes the autobuilder to find false changes in the results of
> >> regression tests (such messages should be redirected to appropriate .jtr
> >> file). This behaviour can be seen here for example:
> >>
> >> http://icedtea.classpath.org/pipermail/testresults/2011-July/003284.html
> >> http://icedtea.classpath.org/pipermail/testresults/2011-July/003288.html
> >>
> >> To fix this issue it's AFAIK necessary to run the test in othervm mode.
> >>
> >> ChangeLog entry:
> >>
> >> 2011-07-12  Pavel Tisnovsky  <ptisnovs at redhat.com>
> >>
> >>         * Makefile.am: added new patch
> >>         * patches/jtreg-ConstructDeflaterInput-fix.patch:
> >>         Regression test jdk/test/java/util/zip/ConstructDeflaterInput.java
> >>         should be run in othervm mode to not to print messages to JTreg
> >>         log files (such messages must be stored in .jtr file).
> >>
> >> Can anybody please review this change?
> >>
> >> Thank you in advance,
> >> Pavel
> > 
> > I don't follow this; surely the fix should be to redirect the output as you suggest?
> > 
> 
> Standard and error output is redirected automagically by JTreg tool, but
>  the "end" method is called from JVM when the test is already finished
> and the appropriate .jtr file is closed.
> 

Ok, then yes this looks fine (assuming it fixes the issue).
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37