Reviewer needed: (IcedTea6 HEAD) added all required source files for reg.test hotspot/7020373, removed binary stuff
Pavel Tisnovsky
ptisnovs at redhat.com
Tue Jul 19 04:19:44 PDT 2011
Dr Andrew John Hughes wrote:
> On 12:30 Mon 18 Jul , Pavel Tisnovsky wrote:
>> Greetings,
>>
>> I'd like to push fix for a regression test hotspot/7020373 into IcedTea6
>> HEAD
>> (and similar patch to IcedTea7 if it will be approved). This fix contains
>> GenOOMCrashClass.java source written by Marc Schoenefeld (Red Hat), I just
>> fixed two minor issues in it (because this generator can be used for
>> creating
>> various types of classes). The fix also contains changed script file used by
>> JTreg tool to run the regression test. Now this test do the following steps:
>>
>> 1) compile GenOOMCrashClass.java ("class generator")
>> 2) run GenOOMCrashClass java to generate the reproduced class file
>> 3) run the reproducer class file
>>
>> If this fix is applied, the following patch is not needed:
>> patches/jtreg-7020373-add-ignore-tag.patch
>>
>> (This change in Makefile.am is also part of the patch).
>>
>> ChangeLog entry:
>>
>> 2011-07-18 Marc Schoenefeld <mschoene at redhat.com>
>> Pavel Tisnovsky <ptisnovs at redhat.com>
>>
>> * Makefile.am: added new patch
>> * patches/jtreg-hotspot-Test7020373-fix.patch:
>> Fix for regression test hotspot/7020373, added missing
>> source used to create the reproducer.
>>
>>
>
> The indentation looks wrong on the new file. Otherwise, ok.
>
> For 7, it will need to go into the forest.
>
Andrew,
thank you for your review, I'll fix it.
Pavel
More information about the distro-pkg-dev
mailing list