RFC: Patch for Bug#749 (sun.applet.PluginStreamHandler#handleMessage(String) really slow)

[Deepak Bhole]

* Denis Lila <dlila at redhat.com> [2011-07-20 16:08]:
> Hi Deepak.
> 
> > ping2?
> 
> If there is no "privileges" but there is "src", won't src be
> included in rest? I'm pretty sure in the previous version
> src was not included in rest, so if the answer to my question
> is "yes", this would be a change in behaviour.
>

Hi Denis,

There have been no code changes between any of the patches (i.e. between the
original patch posted on bugzilla, the first iteration I posted, or this one).
The only changes have been doc/spacing related -- I just double checked.

As for no privileges but src, I don't see how it would get included..
the code-block is:

        // is there a src?
        if ("src".equals(msgComponents[0])) {
            src = msgComponents[1];
            oldPos = pos;
            pos = readPair(message, oldPos, msgComponents);
        }

        // is there a privileges?
        if ("privileges".equals(msgComponents[0])) {
            String privs = msgComponents[1];
            privileges = privs.split(",");
            oldPos = pos;
        }

        // rest
        if (message.length() > oldPos) {
            rest = message.substring(oldPos);
        }

So if there is no privileges, oldPos will be where pos was right after the src
value. OTOH if there were privileges, oldPos will be right after the privileges
value.

Cheers,
Deepak
 
> Regards,
> Denis.
> 
> ----- Original Message -----
> > * Deepak Bhole <dbhole at redhat.com> [2011-07-08 11:45]:
> > > * Deepak Bhole <dbhole at redhat.com> [2011-07-05 11:16]:
> > > > * Andrew John Hughes <ahughes at redhat.com> [2011-07-04 21:48]:
> > > >
> > > ...
> > > > New patch with updated docs attached. Thanks for taking a look!
> > > >
> > >
> > > ping?
> > >
> > 
> 
> > 
> > Deepak
> > 
> > > Deepak