[RFC][PATCH][icedtea-web]: Added support for signed JNLP file- Updated Patch

[Jiri Vanek]

On 07/20/2011 11:24 PM, Dr Andrew John Hughes wrote:
> On 16:26 Wed 20 Jul     , Deepak Bhole wrote:
>> * Saad Mohammad<smohammad at redhat.com>  [2011-07-19 11:04]:
>>> I have attached the updated copy of Patch1.
>>>
>>> On 07/19/2011 02:47 AM, Jiri Vanek wrote:
>>>>>
>>>>> I hope this is the 110% for Patch1! ;)
>>>> 99% ;)
>>>
..snip...
>
> The use of new String and casting seems wrong.  I'm not sure what e.nextElement is returning
> but that enumeration should be using generics.

This method was refactored to return pure list<String> and is now working correctly.

>
> Can xml not return the number of element names beforehand?
Bad luck. No:(
>
> I'm not familiar with this XML API.  Where is it from?  Doesn't look like JAXP.
This is tiny html parser coded directly inside icedtea-web.... not sure if it is right choice ... but is is here very long tim and a several things depnde on him. It was chosen because he is much m,ore tolerant then xml parsers.
Weather it is benefit is question,, but it was decided long ago and is working fine.

>
>> I will leave all of the test case reviews to Jiri :)
>>
>> Cheers,
>> Deepak
>

J