[RFC][PATCH][icedtea-web]: Added support for signed JNLP file- Updated Patch

[Deepak Bhole]

* Jiri Vanek <jvanek at redhat.com> [2011-07-21 03:19]:
> On 07/20/2011 10:26 PM, Deepak Bhole wrote:
> >* Saad Mohammad<smohammad at redhat.com>  [2011-07-19 11:04]:
> >>>  I have attached the updated copy of Patch1.
> >>>
> >>>  On 07/19/2011 02:47 AM, Jiri Vanek wrote:
> >>>>>  >>
> >>>>>  >>I hope this is the 110% for Patch1! ;)
> >>>>  >99% ;)
> >>>
> >>>  This is for sure the 110% ;)
> >>>
> >>>  --
> >>>  Cheers,
> >>>  Saad Mohammad
> >>>
> >Hi Saad,
> >
> >I have a few minor corrections for this one...
> >
> >>>  +
> >>>  +            if (appTemplate == null&&  launchJNLP == null)
> >>>  +                throw new NullPointerException(
> >>>  +                        "Template JNLP file and Launching JNLP file are both null.");
> >>>  +            else if (appTemplate == null)
> >>>  +                throw new NullPointerException("Template JNLP file is null.");
> >>>  +            else if (launchJNLP == null)
> >>>  +                throw new NullPointerException("Launching JNLP file is null.");
> >>>  +
> >Throwing RuntimeExceptions is generally not a good idea. Consider making
> >the above a checked exception.
> 
> I believe nullpointer exception is correct here. Or it will make mess later.
> Although to repalce it with JNLMatch exception can do no harm.
> 

I guess it is a matter of preference. I generally avoid them because
the API user then has to be aware of it. In this case, it is not even
mentioned in the Javadocs that the method throws an NPE...

Cheers,
Deepak