[RFC][PATCH][icedtea-web]: Added support for signed JNLP file- Updated Patch

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-07-21 09:35]:
> On 07/15/2011 10:21 AM, Saad Mohammad wrote:
> >I have updated both the patches that includes the change that you have
> >recommended and requested.
> 
...
...
> >+                        if (signer.allJarsSigned()) { // If the jar is signed
> >+                            URL location = jars[i].getLocation();
> >+                            File localFile = tracker.getCacheFile(location);
> >+
> >+                            if (localFile == null) {
> >+                                throw new JNLPMatcherException(
> >+                                        "Could not locate jar file, returned null");
> >+                            }
> >+
> 
> Looking at the code that catches this exception, it sounds like if
> the jar could not be cached the application aborts? Perhaps you
> should just assume failure in matching jnlp files? Or treat it the
> same way as if signed jnlp files are not present?
>

I thought we had this discussion on IRC before.. I may be mistaken, but
didn't we determine that there should never be a case where caching is
not possible? If so, I think aborting here would be the right thing to
do..

Cheers,
Deepak