[RFC][PATCH][icedtea-web]: Added support for signed JNLP file- Updated Patch

[Saad Mohammad]

On 07/21/2011 09:51 AM, Jiri Vanek wrote:
> On 07/21/2011 03:31 PM, Dr Andrew John Hughes wrote:
>> On 09:21 Thu 21 Jul     , Jiri Vanek wrote:
> ..snip...
>>>>
>>>> The use of new String and casting seems wrong.  I'm not sure what 
>>>> e.nextElement is returning
>>>> but that enumeration should be using generics.
>>>
>>> This method was refactored to return pure list<String>  and is now 
>>> working correctly.
>>>
>>
>> So where's the new patch?
>>
>>>>
> ..snip...
>
> You are right. This method is relict. It was fixed in patch by correct 
> version  but this relict remains.
> This method you are mentioning is in commented section. I do not know 
> why there is such a big commented section (some kind of "class backup" 
> ) (If Saad did this it must be fixed)
> I will try to find an guilty one;)
>
> J. 
I will save u trouble! It wasn't me! :D.
I didn't add the commented section. It was there from the very beginning 
(rev 0). Should I remove the commented section on my next patch? I don't 
see any relevance for it to be there.

-- 
Cheers,
Saad Mohammad