[RFC] One line fix for PR763

[Deepak Bhole]

* Dr Andrew John Hughes <ahughes at redhat.com> [2011-07-25 19:48]:
> On 13:30 Fri 22 Jul     , Deepak Bhole wrote:
> > Hi,
> > 
> > Attached is a simple fix for PR763. Okay for HEAD and 1.0/1.1?
> > 
> > ChangeLog:
> > 2011-07-22  Deepak Bhole <dbhole at redhat.com>
> > 
> >     PR763: Oanda 's online trading app doesn't run on linux
> >     * netx/net/sourceforge/jnlp/runtime/JNLPSecurityManager.java
> >     (checkExit): Print exit-access-denied message to stderr rather than
> >     throwing an exception.
> > 
> > Cheers,
> > Deepak
> 
> How safe is this?  Where is the code now returning to, instead of throwing
> the exception?
> 


Hi,

Sorry, I forgot to reply back. Omair found an issue with this patch. I
will be rewriting it and posting a new version as soon as I can.

Cheers,
Deepak

> > diff -r 6bfd819570c1 NEWS
> > --- a/NEWS	Thu Jul 21 15:11:38 2011 -0400
> > +++ b/NEWS	Fri Jul 22 13:27:52 2011 -0400
> > @@ -14,6 +14,7 @@
> >  	- RH718170, CVE-2011-2514: Java Web Start security warning dialog manipulation
> >  * Plugin
> >    - PR749: sun.applet.PluginStreamHandler#handleMessage(String) really slow
> > +  - PR763: Oanda's online trading app doesn't run on linux
> >  
> >  New in release 1.1 (2011-XX-XX):
> >  * Security updates
> > diff -r 6bfd819570c1 netx/net/sourceforge/jnlp/runtime/JNLPSecurityManager.java
> > --- a/netx/net/sourceforge/jnlp/runtime/JNLPSecurityManager.java	Thu Jul 21 15:11:38 2011 -0400
> > +++ b/netx/net/sourceforge/jnlp/runtime/JNLPSecurityManager.java	Fri Jul 22 13:27:52 2011 -0400
> > @@ -449,8 +449,10 @@
> >          Class stack[] = getClassContext();
> >          if (!exitAllowed) {
> >              for (int i = 0; i < stack.length; i++)
> > -                if (stack[i].getClassLoader() != null)
> > -                    throw new AccessControlException("Applets may not call System.exit()");
> > +                if (stack[i].getClassLoader() != null) {
> > +                    System.err.println("Applets may not call System.exit()");
> > +                    return;
> > +                }
> >          }
> >  
> >          super.checkExit(status);
> 
> 
> -- 
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37