Review Request: zero-methodHandle 7009923-regression

[Dr Andrew John Hughes]

On 11:00 Wed 27 Jul     , Xerxes Rånby wrote:
> On 2011-07-27 02:26, Dr Andrew John Hughes wrote:
> > On 17:01 Tue 12 Jul     , Xerxes Rånby wrote:
> >> On 2011-07-12 16:58, Andrew John Hughes wrote:
> >>> On Tue, Jul 12, 2011 at 04:46:39PM +0200, Xerxes Rånby wrote:
> >>>> Hi all!
> >>>>
> >>>> This webrev updates Zero to handle the
> >>>> Exceptions::throw_stack_overflow_exception API change.
> >>>>
> >>>> http://labb.zafena.se/openjdk/zero-methodHandle-7009923-regression/
> 
> >>> Have you pushed this to any of the IcedTea repositories?
> >>
> >> No. i have only posted the patch to the icedtea bugzilla:
> >> http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=753
> >
> > Please push such fixes to IcedTea in future.
> > I've added this to the IcedTea7 forest.
> 
> Thank you for merging this patch so that it gets included before the 28'th

What's the 28th got to do with anything? We haven't yet set any specific release
date for IcedTea7 2.0.

, I will quickly 
> fill in its current upstream status:
> 
> The patch have been picked up upstream and been placed in a pending review queue:
> http://hg.openjdk.java.net/mlvm/mlvm/hotspot/file/tip/meth-zero-7066143.patch
> I have since then been waiting some weeks for the patch to get reviewed.
> 
> Yesterday on the 26'th of July Christian have started to examining the patch.
> http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/2011-July/005968.html
> 
> When it gets merged upstream and gets assigned a bug id then we can simply merge in the 
> change from upstream.

It's already in IcedTea7.  Job done.

> 
> >  I don't know which versions of
> > IcedTea6 it affects, but it will need to go there as well.
> 
> No, This patch do not need to be backported to IcedTea 6 unless the whole invoke dynamic 
> JSR292 gets backported, wich are unlikely to happen since its a OpenJDK 7 feature.
> 

I guess we'll know when I get time to add hs21 support to IcedTea6 HEAD.  A stable branch
has been around for a while.  If you have the time, you can do it instead.  Just needs
a hotspot.map update, a few acinclude.m4/README changes and lots of testing :-)

> Cheers
> Xerxes

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37