Reviewer needed: backport of "S6669869: Beans.isDesignTime() and other queries should be per-AppContext" into IcedTea6 HEAD

[Pavel Tisnovsky]

Dr Andrew John Hughes wrote:
> On 15:16 Wed 27 Jul     , Pavel Tisnovsky wrote:
>> Greetings,
>>
>> is it possible to push the backport of fix "S6669869:
>> Beans.isDesignTime() and other queries should be per-AppContext"
>> into IcedTea6 HEAD please?
>>
>> The behaviour of this fix was checked on RHELs.
>>
>> Please note, that the fix seems to be long and difficult, but in fact
>> the changes are quite simple (four lines of code contains the fix, other
>> changes are just caused by not using full class names with theirs packages).
>>
> 
> Ugh, I wish they wouldn't create such noisy changesets.
I'm sorry, blame Oracle ;-)
> 
>> Here's ChangeLog entry:
>>
>> 2011-07-27  Pavel Tisnovsky  <ptisnovs at redhat.com>
>>
>>         * Makefile.am: added new patch
>>         * NEWS: updated with backport
>>         *
>> patches/openjdk/6669869-Beans_isDesignTime_should_be_per-AppContext.patch:
>>         Backport of 6669869.
>>
>>
>> Can anybody please review this change?
>>
> 
> I'm not sure about this.  Won't it change the runtime behaviour of these methods?

This change allows to call both methods (namely isDesignTime() &
isGuiAvailable()) also from other application context. If this method is
called from current app. context, nothing has changed. AFAIK - these
method are quite useless when they can not be called from other context,
especially in the case of applets.

P.