Review Request: zero/shark doesn't build after b147-fcs

Dr Andrew John Hughes ahughes at redhat.com
Thu Jul 28 07:02:42 PDT 2011


On 07:25 Thu 28 Jul     , Chris Phillips wrote:
> Hi Christian,
> 
> Hmm missed this yesterday,
> The webrev is updated...
> 
> http://lgonqn.org/temp/ChrisPhi/webrev-methodHandles_zero.hpp-missing++
> 

Can you update IcedTea7 with the change? The earlier patch already went in.

Thanks.

> 
> Chris
> 
> On 27/07/11 02:31 PM, Christian Thalinger wrote:
> > On Jul 15, 2011, at 4:51 PM, Gary Benson wrote:
> >
> >> Chris Phillips wrote:
> >>> http://lgonqn.org/temp/ChrisPhi/webrev-sharkContext.hpp-typo-in-assert/
> >> Nice catch :)
> >>
> >>> http://lgonqn.org/temp/ChrisPhi/webrev-methodHandles_zero.hpp-missing/
> >> You could probably make adapter_code_size be 0, or something small
> >> 1ike 1*k.  Nothing will presumably be generated into these buffers
> >> after all?
> > Chris, can you update the webrev so I can be sure the change works?
> >
> > -- Christian
> >
> >> Cheers,
> >> Gary
> >>
> >> -- 
> >> http://gbenson.net/
> >
> >
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37



More information about the distro-pkg-dev mailing list