[RFC][IcedTea-Web]: Fix for PR464

[Dr Andrew John Hughes]

On 20:02 Tue 07 Jun     , Andrew Su wrote:
> Hello,
> 
> This patch is to allow plugin to run sites that use jnlp_href to specify parameters for applets through a jnlp file.
> 
> Reported in PR464: http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=464
> 
> ChangeLog:
> 
> 2011-06-07  Andrew Su  <asu at redhat.com>
> 
>         * NEWS: Updated.
>         * netx/net/sourceforge/jnlp/JNLPFile.java:
>         (JNLPFile): Calls new constructor.
>         (JNLPFile): New constructor to take an option for forcing a codebase.
>         (JNLPFile): Call parse with extra parameter.
>         (parse): Use the given codebase passed in if we did not find one.
>         * netx/net/sourceforge/jnlp/Parser.java:
>         (Parser): Calls new constructor.
>         (Parser): New constructor which takes in a codebase as a last option.
>         * netx/net/sourceforge/jnlp/PluginBridge.java:
>         (jars): Changed to use HashSet instead of String[].
>         (PluginBridge): Calls new JNLPFile's constructor with current
>         codebase, and adds any jars specified in the JNLP file.
>         (getResources): Updated to work with HashSet of jars.
> 
> 
> For the change in NEWS, wasn't sure which category to put it under.. (placed it under netx).
> Ok for HEAD?
> 
> Cheers,
>   Andrew

NEWS change looks fine.  What I don't understand is the motivation to
do this String[] to HashSet change in this patch; I think it should be
changed in a separate patch if really necessary.

This:

>  
> -                        for (int i = 0; i < jars.length; i++)
> -                            if (jars[i].length() > 0)
> -                                jarDescs.add(new JARDesc(new URL(codeBase, jars[i]),
> +                        Iterator<String> it = jars.iterator();
> +                        while (it.hasNext()) {
> +                            String name = it.next();
> +                            if (name.length() > 0)
> +                        	jarDescs.add(new JARDesc(new URL(codeBase, name),
>                                          null, null, false, true, false, true));
> +                        }
>  

is identical AFAICS, bar the change to JARDesc constructor call.

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37