IcedTea7 build failure + patch to fix this issue (reviewer needed)

[Mark Wielaard]

On Wed, 2011-06-08 at 18:27 +0100, Dr Andrew John Hughes wrote:
> On 15:23 Mon 06 Jun     , Mark Wielaard wrote:
> > On Mon, June 6, 2011 15:02, Pavel Tisnovsky wrote:
> > > currently it's not possible to build IcedTea7 because of wrong sha2sums
> > > of all tarballs. As Mark Wielaard figured out (thanks!) it is caused by
> > > changes made in .hg_archival.txt file, probably in time when new tag is
> > > created (Mark - am I right?).
> > 
> > Yes. Unfortunately hg archive tries to be helpful. And if you add a tag
> > for a revision it will happily record that information in the
> > .hg_archival.txt file. Which of course then alters the checksum even though
> > all other bits are the same. This happened when the icedtea-1.4 tag was
> > added.
> > 
> 
> What 'icedtea-1.4' tag?  Do you mean 'icedtea-1.14'?

Yes.

> > I guess the only way to work around that in the future is for people to
> > tag a tree that the icedtea Makefile.am refers to before they add the
> > checksum value.
> > 
> > Thanks for catching and fixing it.
> > Hopefully this won't happen too often in the future.
> > 
> This looks like a problem with the IcedTea server.  We didn't see this problem
> when using the OpenJDK servers as far as I'm aware.  Sounds like we need to
> switch back if the IcedTea server can't be fixed.  IcedTea7 will accrue many
> new tags as new pulls are made e.g.

It isn't a problem if the tags are already there on the changeset. Which
I think was always the case before. Only this one time a tag was added
after we started using the revision (and that changes the checksum on
the hg archive tar ball for that revision, since then it gets the tag
name added).

It is only a problem if a revision doesn't have a tag yet, but is used
in the Makefile.am already as base and then a tag is later added to that
revision. That is certainly a pita. But we can work around it by only
using tagged revisions in the Makefile.am (or not retroactively adding a
tag to a revision once we start using it with a calculated checksum).

Cheers,

Mark