[RFC][netx]: jnlp app closing issue

Andrew Su asu at redhat.com
Fri Jun 10 06:31:25 PDT 2011



----- Original Message -----
> From: "Denis Lila" <dlila at redhat.com>
> To: distro-pkg-dev at openjdk.java.net
> Sent: Thursday, June 9, 2011 5:54:26 PM
> Subject: [RFC][netx]: jnlp app closing issue
> Hi.
> 
> I would like to push the above two patches.
> 
> The first fixes a problem where
> javaws http://www.crossftp.com/crossftp.jnlp
> will keep running in the background even after there is an
> error while loading.
> 
> The second is just an improvement (IMO) in the jnlp splashscreen.
> It is motivated by the fact that the splashscreen had to be
> closed manually in the above example.
> 
> ChangeLog (for the first patch):
> 
> 2011-06-09 Denis Lila <dlila at redhat.com>
> 
> * netx/net/sourceforge/jnlp/cache/DefaultDownloadIndicator.java:
> (frameMutex): New mutex to synchronize accesses to "frame".
> (getListener): Make almost all of it synchronized on frameMutex.
> (disposeListener): Sync hider's body around frameMutex and call
> dispose on the frame so that the awt threads die when they should.
> (addProgressPanel): Sync "frame" usage.
> 
> 
> Second patch:
> 
> 2011-06-09 Denis Lila <dlila at redhat.com>
> 
> * netx/net/sourceforge/jnlp/GuiLaunchHandler.java:
> (mutex): New mutex for synchronizing splashScreen.
> (closeSplashScreen): New method to hide and dispose
> splashScreen.
> (launchStarting): Call closeSplashScreen instead of doing it
> inline.
> (launchInitialized): Sync splashScreen creation.
> (validationError, launchError): Call closeSplashScreen.
> 
> Any comments are appreciated.

Hey,

I've taken a look at the patch, they both look good for HEAD.

Cheers,
  Andrew



More information about the distro-pkg-dev mailing list