[RFC][icedtea6][pulse-java.jar]

[Denis Lila]

> Does this work when bootstrapping? -J-Xbootclasspath/p is non-standard
> and not supported by gij.

You're right, it doesn't. It seems I broke the build with
that patch. Attached is a fix for both the original issue
and the regression. I tested it with both the bootstrap build
and "make pulse-java". Both work as they should now.

ChangeLog:
2011-06-13  Denis Lila  <dlila at redhat.com>

        * Makefile.am: Add back the -classpath option
        to javah in building the pulse audio header
        files. The bootstrap javah doesn't recognize
        -J-Xbootclasspath/p: so it couldn't find the
        classfiles.


Ok to push?

Regards,
Denis.

----- Original Message -----
> On 15:54 Fri 10 Jun , Denis Lila wrote:
> > Hi.
> >
> > The attached patch fixes a problem where, during the pulse
> > audio build, the header files were built for the system
> > pulse audio classes instead of the classes for the icedtea6
> > being built.
> >
> > ChangeLog:
> >
> > 2011-06-10 Denis Lila <dlila at redhat.com>
> > 	* Makefile.am
> > 	(stamps/pulse-java-headers.stamp): Prepend the java build directory
> > 	to the boot class path to avoid generating headers for the system
> > 	pulse-java classes.
> >
> > Ok to push?
> >
> > Regards,
> > Denis.
> 

> 
> > diff -r 349dee8c337a Makefile.am
> > --- a/Makefile.am Thu Jun 09 13:42:07 2011 -0400
> > +++ b/Makefile.am Fri Jun 10 15:52:55 2011 -0400
> > @@ -1745,15 +1745,15 @@
> >
> >  stamps/pulse-java-headers.stamp: stamps/pulse-java-class.stamp
> >  	mkdir -p $(PULSE_JAVA_NATIVE_BUILDDIR)
> > - $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR) -classpath
> > $(PULSE_JAVA_CLASS_DIR) \
> > + $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR)
> > -J-Xbootclasspath/p:$(PULSE_JAVA_CLASS_DIR) \
> >  	  org.classpath.icedtea.pulseaudio.EventLoop ; \
> > - $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR) -classpath
> > $(PULSE_JAVA_CLASS_DIR) \
> > + $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR)
> > -J-Xbootclasspath/p:$(PULSE_JAVA_CLASS_DIR) \
> >  	  org.classpath.icedtea.pulseaudio.Stream ; \
> > - $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR) -classpath
> > $(PULSE_JAVA_CLASS_DIR) \
> > + $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR)
> > -J-Xbootclasspath/p:$(PULSE_JAVA_CLASS_DIR) \
> >  	  org.classpath.icedtea.pulseaudio.Operation; \
> > - $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR) -classpath
> > $(PULSE_JAVA_CLASS_DIR) \
> > + $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR)
> > -J-Xbootclasspath/p:$(PULSE_JAVA_CLASS_DIR) \
> >  	  org.classpath.icedtea.pulseaudio.PulseAudioSourcePort ; \
> > - $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR) -classpath
> > $(PULSE_JAVA_CLASS_DIR) \
> > + $(BOOT_DIR)/bin/javah -d $(PULSE_JAVA_NATIVE_BUILDDIR)
> > -J-Xbootclasspath/p:$(PULSE_JAVA_CLASS_DIR) \
> >  	  org.classpath.icedtea.pulseaudio.PulseAudioTargetPort ; \
> >  	mkdir -p stamps
> >  	touch stamps/pulse-java-headers.stamp
> 
> 
> --
> Andrew :)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and IcedTea
> http://www.gnu.org/software/classpath
> http://icedtea.classpath.org
> PGP Key: F5862A37 (https://keys.indymedia.org/)
> Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
-------------- next part --------------
A non-text attachment was scrubbed...
Name: build-regression-fix.patch
Type: text/x-patch
Size: 2072 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110613/bc5688ea/build-regression-fix.patch