[icedtea6][RFC] Fix: xalan/xerces dependencies issues in F15 build
Deepak Bhole
dbhole at redhat.com
Mon Jun 13 08:53:46 PDT 2011
* Danesh Dadachanji <ddadacha at redhat.com> [2011-06-07 16:12]:
> Hi,
>
> Here is a fix for the xalan/xerces dependencies problem with
> building in F15. It checks if the xml jar is needed and then
> symlinks accordingly. I've tested it on F13-15 and it worked fine.
>
> ChangeLog:
> +2011-07-06 Danesh Dadachanji <ddadacha at redhat.com>
> + * Makefile.am: Use explicit xml-commons locations if necessary.
> + * acinclude.m4: Added explicit xml-commons check.
> + (IT_CHECK_IF_INSTANTIABLE): Added generic macro to instantiate any
> + class. Paramaters are the define, name of the class, paramaters
> + for instatiation and (optional) classpath.
> + * configure.ac: Invoke IT_FIND_XML_COMMONS_APIS_JAR macro after
> + IT_FIND_XERCES2_JAR, assigns XML_COMMONS_APIS_JAR if necessary.
> +
>
> I added a macro similar to IT_CHECK_FOR_CLASS called
> IT_CHECK_IF_INSTANTIABLE that instantiates the second paramater and
> assigns $1_INSTANTIABLE=yes if no exceptions occur, no otherwise.
> This is in addition to the AM_CONDITIONAL being set (as in the
> original macro). It also takes in an optional classpath paramater.
>
> - I couldn't use the existing one because class.toString() wasn't
> enough to throw the same exception as in the build. You have to
> instantiate org.apache.xerces.dom.DeferredDocumentImpl in order to
> do this.
>
> - I needed the classpath paramater because I had to explicitly
> specify the xalan/xerces jars, the other macro only checks the
> current dir.
>
> - The conditional created is also not accessible in configure.ac so
> I had to create the dummy $1_INSTANTIABLE var to do the check there.
> The conditional can only be accessed in Makefile.am, whcih can't
> access the function that finds the path of xml-commons. Hence
> putting the checks there isn't easy either.
>
> - I could only find the Fedora/Gentoo-specific paths to where the
> xml-commons jar is located. Does anyone know others?
>
> Regards,
> Danesh
Hi,
Comments inline:
> diff -r e191909a7c6e ChangeLog
> --- a/ChangeLog Mon May 30 19:21:44 2011 +0100
> +++ b/ChangeLog Tue Jun 07 15:24:37 2011 -0400
> @@ -1,3 +1,12 @@
> +2011-07-06 Danesh Dadachanji <ddadacha at redhat.com>
> + * Makefile.am: Use explicit xml-commons locations if necessary.
> + * acinclude.m4: Added explicit xml-commons check.
> + (IT_CHECK_IF_INSTANTIABLE): Added generic macro to instantiate any
> + class. Paramaters are the define, name of the class, paramaters
> + for instatiation and (optional) classpath.
> + * configure.ac: Invoke IT_FIND_XML_COMMONS_APIS_JAR macro after
> + IT_FIND_XERCES2_JAR, assigns XML_COMMONS_APIS_JAR if necessary.
> +
> 2011-05-30 Andrew John Hughes <ahughes at redhat.com>
>
> * patches/openjdk/7036220-shark_llvm_29_headers.patch:
> diff -r e191909a7c6e Makefile.am
> --- a/Makefile.am Mon May 30 19:21:44 2011 +0100
> +++ b/Makefile.am Tue Jun 07 15:24:37 2011 -0400
> @@ -1271,7 +1271,12 @@ stamps/bootstrap-directory-ecj.stamp: st
> ln -sf $(XALAN2_JAR) $(ECJ_BOOT_DIR)/lib/endorsed/xalan-j2.jar && \
> ln -sf $(XALAN2_SERIALIZER_JAR) \
> $(ECJ_BOOT_DIR)/lib/endorsed/xalan-j2-serializer.jar && \
> - ln -sf $(XERCES2_JAR) $(ECJ_BOOT_DIR)/lib/endorsed/xerces-j2.jar
> + ln -sf $(XERCES2_JAR) $(ECJ_BOOT_DIR)/lib/endorsed/xerces-j2.jar && \
> + if test -n "$(XML_COMMONS_APIS_JAR)"; \
> + then \
> + ln -sf $(XML_COMMONS_APIS_JAR) \
> + $(ECJ_BOOT_DIR)/lib/endorsed/xml-commons-apis.jar; \
> + fi
The indentation above seems incorrect (the fi is more indented than the
if). Please double check.
> mkdir -p $(ECJ_BOOT_DIR)/jre/lib && \
> cp $(SYSTEM_JDK_DIR)/jre/lib/rt.jar $(ECJ_BOOT_DIR)/jre/lib/rt.jar && \
> ln -sf $(SYSTEM_JDK_DIR)/jre/lib/$(JRE_ARCH_DIR) \
> diff -r e191909a7c6e acinclude.m4
> --- a/acinclude.m4 Mon May 30 19:21:44 2011 +0100
> +++ b/acinclude.m4 Tue Jun 07 15:24:37 2011 -0400
> @@ -725,6 +725,35 @@ AC_DEFUN([IT_FIND_XERCES2_JAR],
> AC_SUBST(XERCES2_JAR)
> ])
>
> +AC_DEFUN([IT_FIND_XML_COMMONS_APIS_JAR],
> +[
> + AC_MSG_CHECKING([for a xml-commons-apis jar])
<rant>
"for an xml-commons-apis jar"
</rant>
> + AC_ARG_WITH([xml-commons-apis-jar],
> + [AS_HELP_STRING(--with-xml-commons-apis-jar,specify location of the xml-commons-apis jar)],
> + [
> + if test -f "${withval}" ; then
> + XML_COMMONS_APIS_JAR="${withval}"
> + fi
Why -f? A link should be acceptable too.
> + ],
> + [
> + XML_COMMONS_APIS_JAR=
> + ])
> + if test -z "${XML_COMMONS_APIS_JAR}"; then
> + if test -e "/usr/share/java/xml-commons-apis.jar"; then
> + XML_COMMONS_APIS_JAR=/usr/share/java/xml-commons-apis.jar
> + elif test -e "/usr/share/xml-commons/lib/xml-apis.jar"; then
> + XML_COMMONS_APIS_JAR=/usr/share/xml-commons/lib/xml-apis.jar
> + else
> + AC_MSG_RESULT(no)
> + fi
> + fi
These search locations should account for Debian, Gentoo, SuSE and
Ubuntu at the very least.
You can look on-line for package listings.. e.g. debian has:
http://packages.debian.org/squeeze/all/libxml-commons-external-java/filelist
> + if test -z "${XML_COMMONS_APIS_JAR}"; then
> + AC_MSG_ERROR("A xml-commons-apis jar was not found.")
> + fi
<rant2>
"An xml-commons-apis jar..."
</rant2> :)
> + AC_MSG_RESULT(${XML_COMMONS_APIS_JAR})
> + AC_SUBST(XML_COMMONS_APIS_JAR)
> +])
> +
> AC_DEFUN([IT_FIND_RHINO_JAR],
> [
> AC_MSG_CHECKING([whether to include Javascript support via Rhino])
> @@ -1374,6 +1403,63 @@ AM_CONDITIONAL([LACKS_$1], test x"${it_c
> AC_PROVIDE([$0])dnl
> ])
>
> +dnl Generic macro to instantiate a Java class
> +dnl Takes three arguments: the name of the macro,
> +dnl the name of the class and the instantiation
> +dnl paramaters. The macro name is usually the
> +dnl name of the class with '.' replaced by '_'
> +dnl and all letters capitalised.
> +dnl Also takes optional classpath paramater.
> +dnl e.g. IT_CHECK_FOR_INSTANTIABLE_CLASS([JAVA_LANG_INTEGER],
> +dnl [java.lang.Integer],[0],[./bin])
> +AC_DEFUN([IT_CHECK_IF_INSTANTIABLE],[
> +AC_CACHE_CHECK([if $2 is instantiable], it_cv_$1, [
I think it would be better to make this variadic. Though then, the
classpath would have to be moved to #3 and made non-optional.
> +CLASS=Test.java
> +BYTECODE=$(echo $CLASS|sed 's#\.java##')
> +mkdir tmp.$$
> +cd tmp.$$
> +cat << \EOF > $CLASS
> +[/* [#]line __oline__ "configure" */
> +public class Test
> +{
> + public static void main(String[] args)
> + {
> + new $2($3);
> + }
> +}
> +]
> +EOF
> +
> +if test -z $4; then
> + WITH_CLASSPATH=.
> +else
> + WITH_CLASSPATH=$4:.
> +fi
> +
> +if $JAVAC -cp $WITH_CLASSPATH $JAVACFLAGS -nowarn $CLASS >&AS_MESSAGE_LOG_FD 2>&1; then
> + if $JAVA -classpath $WITH_CLASSPATH $BYTECODE >&AS_MESSAGE_LOG_FD 2>&1; then
> + it_cv_$1=yes;
> + else
> + it_cv_$1=no;
> + fi
> +else
> + it_cv_$1=no;
> +fi
> +])
> +rm -f $CLASS *.class
> +cd ..
> +rmdir tmp.$$
> +
> +if test x"${it_cv_$1}" = "xyes"
> +then
> + $1_INSTANTIABLE=yes
> +else
> + $1_INSTANTIABLE=no
> +fi
> +AM_CONDITIONAL([LACKS_$1], test x"${it_cv_$1}" = "xno")
> +AC_PROVIDE([$0])dnl
> +])
> +
> # Finds number of available processors using sysconf
> AC_DEFUN_ONCE([IT_FIND_NUMBER_OF_PROCESSORS],[
> IT_FIND_TOOL([GETCONF], [getconf])
> diff -r e191909a7c6e configure.ac
> --- a/configure.ac Mon May 30 19:21:44 2011 +0100
> +++ b/configure.ac Tue Jun 07 15:24:37 2011 -0400
> @@ -159,6 +159,15 @@ if test "x$enable_bootstrap" = "xyes"; t
> IT_FIND_XALAN2_JAR
> IT_FIND_XALAN2_SERIALIZER_JAR
> IT_FIND_XERCES2_JAR
> + IT_CHECK_IF_INSTANTIABLE([ORG_APACHE_XERCES_DOM_DEFERREDDOCUMENTIMPL],
> +[org.apache.xerces.dom.DeferredDocumentImpl],[],
> +[$XALAN2_JAR:$XALAN2_SERIALIZER_JAR:$XERCES2_JAR])
> + if test x"${ORG_APACHE_XERCES_DOM_DEFERREDDOCUMENTIMPL_INSTANTIABLE}" = "xno"
> + then
> + IT_FIND_XML_COMMONS_APIS_JAR
> + else
> + XML_COMMONS_APIS_JAR=
> + fi
Rest looks okay to me.
Cheers,
Deepak
> fi
> AC_CONFIG_FILES([javac], [chmod +x javac])
> AC_CONFIG_FILES([javap], [chmod +x javap])
More information about the distro-pkg-dev
mailing list