[icedtea-web] RFC: Rewrite of plugin threading model

Deepak Bhole dbhole at redhat.com
Mon Jun 13 11:27:28 PDT 2011


* Omair Majid <omajid at redhat.com> [2011-06-09 12:01]:
> On 06/09/2011 11:55 AM, Deepak Bhole wrote:
> >* Dr Andrew John Hughes<ahughes at redhat.com>  [2011-06-08 07:56]:
> >>On 16:35 Tue 07 Jun     , Deepak Bhole wrote:
> >>>Hi,
> >>>
> >>>I've been holding back 1.1 for this patch.
> >>>
> >>>This patch adresses PR721:
> >>>http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=721
> >>>
> >>>The patch in fact fixes far more than just that issue (which have
> >>>varying symptoms, all ultimately resulting in a browser crash).
> >>>
> >>>The patch rewrites the threading model of the plug-in such that it
> >>>executes events on the correct thread. Furthermore, it does away with
> >>>all "chromium" workarounds. With this patch, the plugin works
> >>>significantly better with chromium. Furthermore, it no longer crashes
> >>>FF4.
> >>>
> >>>Given the frequency of the newer FF4 crashes, I strongly think this
> >>>patch should go into 1.1. I have kept things to the absolute minimum and
> >>>tested it will all known applets and run the live connect tests. I found
> >>>no regressions vs the current 1.1. The only difference was that there
> >>>were no crashes, so it is much better with the patch.
> >>>
> >>>Okay for 1.1 and HEAD?
> >>>
> >>
> >>Sounds essential for both.  Ok.
> >>
> >
> >Since F15 has 1.0.x and has FF4, I think this patch would make a nice
> >backport for there too. Okay for 1.0?
> >
> 
> Sure, as a bugfix, it think it makes a lot of sense to backport this.
> 

Thanks! Pushed.

Cheers,
Deepak

> Cheers,
> Omair



More information about the distro-pkg-dev mailing list