Reviewer needed - fix for a regression test openjdk/jdk/test/sun/net/www/protocol/file/EncodedMultiByteChar.java in IcedTea6 HEAD
Pavel Tisnovsky
ptisnovs at redhat.com
Tue Jun 14 07:31:18 PDT 2011
Jiri Vanek wrote:
> On 06/14/2011 02:47 PM, Pavel Tisnovsky wrote:
>> Hi all,
>> +@@ -81,5 +84,11 @@
>> + } catch (IOException ioe) {
>> + ioe.printStackTrace();
>> + }
>> ++ finally {
>> ++ System.out.println("test OK");
> Is this "test ok" really ok both when exception is thrown even when it
> is not thrown(when it is in finally bnlok)? Also maybe
> "jtreg-EncodedMultiByteChar.patch main method test ok" can be better
> then just "test ok".
Ah good catch! You are right, this message should be printed outside the
second try-catch-block. I'll fix it.
> I
>> ++ if (file != null) {
>> ++ file.delete();
>> ++ }
More information about the distro-pkg-dev
mailing list