[RFC][icedtea6-pulse-audio]: Start recording corked.

[Denis Lila]

Hi.

This patch makes only one functional change:
it starts recording streams corked (paused).
We used to start them uncorked on a TargetDataLine.open(...)
call, which was a waste because because a line
cannot be read until TargetDataLine.start() is called
on it. Therefore the start() corresponds to
uncorking the stream (which is reflected in
our implementation of start(), which just uncorks
the already uncorked stream).

Other than this, the patch also moves pa_stream_flag_t
constants into java to give the java side control
over how streams are started. The implementation of
native_pa_stream_connect_playback no longer starts
the stream corked explicitly. Rather, it just passes
in the "flags" argument it received from its java
caller (which has set it to CORKED). These changes
are in line with the design of Stream.c, which has
very little logic, and it's mostly just a way for
the java code to make calls into pulse audio.

ChangeLog:
2011-06-16  Denis Lila  <dlila at redhat.com>

    * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/Stream.java
    (NOFLAGS, START_CORKED, INTERPOLATE_TIMING, NOT_MONOTONIC,
    AUTO_TIMING_UPDATE, NO_REMAP_CHANNELS, NO_REMIX_CHANNELS,
    FIX_FORMAT, FIX_RATE, FIX_CHANNELS, DONT_MOVE, VARIABLE_RATE,
    PEAK_DETECT, START_MUTED, ADJUST_LATENCY, EARLY_REQUESTS,
    DONT_INHIBIT_AUTO_SUSPEND, START_UNMUTED, FAIL_ON_SUSPEND):
    New static long variables mirroring pa_stream_flag_t values.
    (native_pa_stream_connect_playback, native_pa_stream_connect_record):
    Change flags parameter to long.
    (connectForPlayback, connectForRecording): Start the stream corked.
    Change formatting to make it more readable.
    * pulseaudio/src/native/org_classpath_icedtea_pulseaudio_Stream.c
    (SET_STREAM_ENUM): Renamed from SET_STREAM_STATE_ENUM, since the 
    macro could have been used for any PA_STREAM constants, not just
    stream states (and indeed, we now use it for flag constants too).
    (Java_org_classpath_icedtea_pulseaudio_Stream_init_1constants):
    Initialize flag constants in addition to the stream states.
    (Java_org_classpath_icedtea_pulseaudio_Stream_native_1pa_1stream_1connect_1playback):
    Change flags parameter to jlong (from jint), remove commented out 
    dead code, remove obsolete comment, and start the stream with whatever
    flags were passed in the flags parameter, instead of ignoring that
    parameter and using PA_STREAM_START_CORKED.
    (Java_org_classpath_icedtea_pulseaudio_Stream_native_1pa_1stream_1connect_1record):
    Change flags parameter to jlong (from jint), remove commented out 
    dead code.


Regards,
Denis.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pa_start_recording_corked.patch
Type: text/x-patch
Size: 10949 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110616/91fb3c57/pa_start_recording_corked.patch