RFC [iceedtea-web] added first set of reproducres

[Omair Majid]

On 06/20/2011 11:23 AM, Jiri Vanek wrote:
>>> diff -r e413e4676929
>>> tests/jnlp_tests/simple/ReadProperties/srcs/ReadProperties.java
>>> --- /dev/null Thu Jan 01 00:00:00 1970 +0000
>>> +++ b/tests/jnlp_tests/simple/ReadProperties/srcs/ReadProperties.java
>>> Mon Jun 20 11:38:50 2011 +0200
>>> @@ -0,0 +1,10 @@
>>> +public class ReadProperties {
>>> +
>>> +
>>> + public static void main(String[] args) {
>>> +
>>> + // System.getProperty("user.name");
>>> + // System.getProperty("user.home");
>>> + System.getProperty(args[0]);
>>> + }
>>> +}
>>
>> I am a little curious as to why the commented out lines are present.
>> Is there a problem with System.getProperty("user.name")? Or is it just
>> leftover code from when you were testing?
>
> I had left them as "documentation" what is expected to be passed through
> arguments. They are left in new patch. Do you really want them removed?

Okay, now I see. But it's not obvious (at least to me :/) from the code. 
Perhaps you might want to add a comment saying that args[0] is expected 
to be "user.name"? FWIW, a similar test for environment uses 
System.getenv("USER"), rather than System.getenv(args[0]).

> +public class AllStackTracesTest {
> +
> +    private static ServerAccess server = new ServerAccess();
> +
> +
> +
> +    @Test
> +    public void AddShutdownHookTestLunch1() throws Exception {
> +        System.out.println("connecting AllStackTraces request");
> +        ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/AllStackTraces.jnlp");
> +        System.out.println(pr.stdout);
> +        System.err.println(pr.stderr);
> +        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.lang.RuntimePermission getStackTrace)"));
> +        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
> +        Assert.assertFalse(pr.stdout.length()>2);
> +        Assert.assertFalse(pr.wasTerminated);
> +        Assert.assertEquals((Integer)0, pr.returnValue);
> +    }
> +
> +
> +
> +
> +
> +    }

There are still some blank lines here.

> +public class ReadPropertiesTest {
> +
> +    private static ServerAccess server = new ServerAccess();
> +
> +
> +
> +    @Test
> +    public void ReadPropertiesLunch1() throws Exception {
> +        System.out.println("connecting ReadProperties request");
> +        ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/ReadProperties1.jnlp");
> +        System.out.println(pr.stdout);
> +        System.err.println(pr.stderr);
> +        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.util.PropertyPermission user.name read)"));
> +        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
> +        Assert.assertFalse(pr.stdout.length()>2);
> +        Assert.assertFalse(pr.wasTerminated);
> +        Assert.assertEquals((Integer)0, pr.returnValue);
> +    }
> +
> + @Test
> +    public void ReadPropertiesLunch2() throws Exception {
> +        System.out.println("connecting ReadProperties request");
> +        ServerAccess.ProcessResult pr=server.executeJavawsHeadless(null,"/ReadProperties2.jnlp");
> +        System.out.println(pr.stdout);
> +        System.err.println(pr.stderr);
> +        Assert.assertTrue(pr.stderr.contains("java.security.AccessControlException: access denied (java.util.PropertyPermission user.home read)"));
> +        Assert.assertFalse(pr.stderr.contains("ClassNotFoundException"));
> +        Assert.assertFalse(pr.stdout.length()>2);
> +        Assert.assertFalse(pr.wasTerminated);
> +        Assert.assertEquals((Integer)0, pr.returnValue);
> +    }
> +
> +
> +
> +
> +
> +    }

Also a lot of blank lines here.

Okay to commit with the extra spaces/newlines removed.

Cheers,
Omair