Reviewer needed - backport 7008106 regression test fix: com/sun/awt/Translucency/WindowOpacity.java into IcedTea6 HEAD

[Jiri Vanek]

Bug description ios clear - In the test should make the frame undecorated.
Solution is clear  -  f.setUndecorated(true);

This can for sure be backported to ensure less vulnereability from swing/awt backports.

Dman.. Backporting of jtreg patches should be excluded from review process.

J

On 06/22/2011 03:35 PM, Pavel Tisnovsky wrote:
> Hi all,
>
> is it possible to backport 7008106 regression test fix:
> com/sun/awt/Translucency/WindowOpacity.java into IcedTea6 HEAD?
>
> Here's ChangeLog entry:
>
> 2011-06-22  Pavel Tisnovsky<ptisnovs at redhat.com>
>
>          * Makefile.am: added new patch
>          * NEWS: updated with backport
>          * patches/openjdk/7008106-WindowOpacity.patch:
>          Backport of 7008106 regression test fix.
>
> NEWS entry is contained in hg_diff generated against recent IcedTea6
> HEAD version.
>
> Can anybody please review this simple backport?
>
> Thank you in advance,
> Pavel
>
>
> hg_diff
>
>
> diff -r 4a46bd6fb3a5 Makefile.am
> --- a/Makefile.am	Wed Jun 22 10:52:24 2011 +0200
> +++ b/Makefile.am	Wed Jun 22 14:53:30 2011 +0200
> @@ -361,7 +361,8 @@
>   	patches/jtreg-ChannelsWrite.patch \
>   	patches/jtreg-bug7036148-test.patch \
>   	patches/jtreg-ReadWriteProfileTest.patch \
> -	patches/openjdk/6818312-com.sun.awt.SecurityWarning.getSize.patch
> +	patches/openjdk/6818312-com.sun.awt.SecurityWarning.getSize.patch \
> +	patches/openjdk/7008106-WindowOpacity.patch
>
>   if WITH_ALT_HSBUILD
>   ICEDTEA_PATCHES += \
> diff -r 4a46bd6fb3a5 NEWS
> --- a/NEWS	Wed Jun 22 10:52:24 2011 +0200
> +++ b/NEWS	Wed Jun 22 14:53:30 2011 +0200
> @@ -34,6 +34,7 @@
>     - S6578583: Modality is broken in windows vista home premium from jdk1.7 b02 onwards.
>     - S6610244: modal dialog closes with fatal error if -Xcheck:jni is set
>     - S7037283, RH712211: Null Pointer Exception in SwingUtilities2.
> +  - S7008106: com/sun/awt/Translucency/WindowOpacity.java test fails.
>   * Bug fixes
>     - PR637: make check should exit with an error code if any regression test failed.
>     - G356743: Support libpng 1.5.
> diff -r 4a46bd6fb3a5 patches/openjdk/7008106-WindowOpacity.patch
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/patches/openjdk/7008106-WindowOpacity.patch	Wed Jun 22 14:53:30 2011 +0200
> @@ -0,0 +1,19 @@
> +# HG changeset patch
> +# User dav
> +# Date 1293624780 -10800
> +# Node ID 8b05f9b91765b7b9da4d2033693e10c1a174a2a5
> +# Parent  39e9d5613145dbdd3973a1ecaa481c679dcfbf8f
> +7008106: com/sun/awt/Translucency/WindowOpacity.java test fails just against jdk7 b122
> +Reviewed-by: dcherepanov
> +
> +diff -r 39e9d5613145 -r 8b05f9b91765 test/com/sun/awt/Translucency/WindowOpacity.java
> +--- openjdk.orig/jdk/test/com/sun/awt/Translucency/WindowOpacity.java	Tue Dec 28 17:13:13 2010 +0300
> ++++ openjdk/jdk/test/com/sun/awt/Translucency/WindowOpacity.java	Wed Dec 29 15:13:00 2010 +0300
> +@@ -64,6 +64,7 @@
> +         boolean passed;
> +
> +         Frame f = new Frame("Opacity test");
> ++        f.setUndecorated(true);
> +
> +         passed = false;
> +         try {