[RFC][icedtea-web]: Added support for signed JNLP file

[Saad Mohammad]

On 06/27/2011 10:21 AM, Jiri Vanek wrote:
>> +                                } catch (IOException e) { //'new 
>> JarFile(localFile)' throws an IOException
>> +                                    e.printStackTrace();
> Is there really some reason why to consume this exception?
I have this exception in case new JarFile() throws an IOException when 
it is being initialized , I want it to to print the stack and move on to 
reading the next jar file.
>> +                                }
>> +                            }
>> +                        }
>> +                    } catch (JNLPVerifyException e) { //Throw e if 
>> signed JNLP file failed to be verified
>> +                        throw e;
> Why this?
I am throwing this exception, so it will stop the  initialization of the 
application. If the two JNLP files fail to be verified/matched  (than it 
throws this exception), throwing 'e' will stop the initialization of the 
application.
>> +
>> +                    } catch (Exception e) {
>> +                        e.printStackTrace();
>> +                    }
> Again -Is there really some reason why to consume this exception? 
> e.print..() is not an reaction to exception. It is escape;)
This catch is for JarSigner.verifyJars(). If while verifying jars throws 
an Exception, it is caught and moves on to reading the next jar file.
>> +                }
>> +                if (JNLPRuntime.isDebug())
>> +                    System.out.println("ENDING check for signed JNLP 
>> file...");
>> +            }
>>           }
If I am still wrong, or if there is a better solution, please feel free 
to correct me. =)
Thanks!

-- 
Cheers,
Saad Mohammad