Reviewer needed: backport of 6796786 and 7042070 fixes into IcedTea6 HEAD

[Andrew John Hughes]

On Tue, Jun 28, 2011 at 03:17:28PM +0200, Jiri Vanek wrote:
> On 06/24/2011 09:49 AM, Pavel Tisnovsky wrote:
> >Hi all,
> >
> >it is possible to backport 6796786 and 7042070 fixes into IcedTea6 HEAD
> >please?
> >
> >hg diff generated against recent IcedTea6 HEAD is included in an
> >attachment. Please note, that these patches should be applied with the
> >following order (6796786 ->  7042070) because the second patch simply
> >fixes issue in a regression test added through the first patch.
> >
> >ChangeLog entry:
> >
> >2011-06-24  Pavel Tisnovsky<ptisnovs at redhat.com>
> >
> >         * Makefile.am: added new patches
> >         * NEWS: updated with backports
> >         * patches/openjdk/6796786-invalid_FP_identity_transform.patch:
> >         * patches/openjdk/7042070-Typo_in_Test6796786.patch:
> >         Backport of 6796786 and 7042070 fixes.
> >
> >Can anybody please review this change?
> >
> >Thank you in advance,
> >Pavel
> 
> 
> I have walked through  patch(es).  With my poor knowledge of C I can not judge 100% (but when it is backport it can be enough) but java side looks  OK.
> Build and test run on F13 upon HEAD is ok for both backports. Please slow down!-D
> 

Yes, please slow down a bit.  Not only is a little annoying having to
continually merge when working on stuff for HEAD, as it invalidates my
testing, but you're not really allowing sufficient time for people to
look at these (the opposite of before where it was too slow...).

In particular, this is a HotSpot patch.  Have you tested it on both
supported versions?  I see no indication of that in your submission.

> Enjoy your commit:)
> 
> J.

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37