[RFC][Icedtea-Web]: Hide unused components in itw-settings.

[Andrew Su]

----- Original Message -----
> From: "Deepak Bhole" <dbhole at redhat.com>
> To: "Andrew Su" <asu at redhat.com>
> Cc: "IcedTea" <distro-pkg-dev at openjdk.java.net>
> Sent: Monday, February 28, 2011 10:21:46 AM
> Subject: Re: [RFC][Icedtea-Web]: Hide unused components in itw-settings.
> * Andrew Su <asu at redhat.com> [2011-02-27 22:47]:
> > Hello,
> >
> >  The attached patch will hide the unused components in itw-settings.
> >  Unused:
> >    Setting cache size.
> >    Selecting another JRE for plugin to bind to.
> >
> >
> > Questions? Comments? Concerns?
> >
> > Cheers,
> >   Andrew
> 
> 
> Indentations are off. In the interest of keeping it looking clean, can
> you
> please fix it so that the // are right beside the code, and aligned?

Fixed.

> e.g.
> 
> 
> > - new SettingsPanel(Translator.R("CPTabRuntimes"),
> > createRuntimesSettingsPanel()),
> > + // new SettingsPanel(Translator.R("CPTabRuntimes"),
> > createRuntimesSettingsPanel()),
> 
> to
> 
> > - new SettingsPanel(Translator.R("CPTabRuntimes"),
> > createRuntimesSettingsPanel()),
> > + // new SettingsPanel(Translator.R("CPTabRuntimes"),
> > createRuntimesSettingsPanel()),
> 
> Also, please add a comment in the code stating why it is disabled, so
> that it
> is not forgotten in the future.

Added.

Sorry for late response, missed the e-mail. Here is the updated patch which fixes the comment spacing and gives a short note about it. 

ChangeLog:

2011-03-01  Andrew Su  <asu at redhat.com>
        * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java
        (createMainSettingsPanel): Commented out unimplemented feature.
        * netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
        (addComponents): Commented out unimplemented feature.


Cheers,
  Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110301_patch1_remove_unimplemented.patch
Type: text/x-patch
Size: 5150 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20110301/0ebe6d9c/20110301_patch1_remove_unimplemented.patch