Reviewer needed - fix for Re: Strange behaviour during javaws -about

[Dr Andrew John Hughes]

On 09:40 Tue 01 Mar     , Pavel Tisnovsky wrote:
> > This was what was really confusing me. The "new Runnable() {...}" bit is 
> > really an inner class, Main$1. Main and HTMLPanel are loaded by netx 
> > itself (which has permissions to access any package), but Main$1 is 
> > loaded by Main, which does not have access to the package 
> > net.sourceforge.jnlp.about. So keeping the invokeLater causes an 
> > AccessControlException (as Main tries to access 
> > net.sourceforge.jnlp.about.Main$1), while removing it makes the 
> > untrusted about application work.
> > 
> > The correct fix, IMHO, would be to change the package of about, so 
> > about.jar can access all it's own classes without security exceptions. 
> > On the other hand, I think that may be an overly complex solution; 
> > removing invokeLater works for now (thought it may break at some point).
> > 
> > Does anyone else have any thoughts about this?
> > 
> Hi Omair and Jiri,
> 
> well one (ugly) solution exists: you can create new class implementing 
> Runnable and inside this class it's run() method can call public method 
> createAndShowGui() from Main by using reference to instance of Main - 
> it's definitely not the clearest solution but should work:
> 
> class GUIAsynchronousThread implements Runnable {
>      private Main main = null;
>      public GUIAsynchronousThread(Main main) {
>          this.main = main;
>      }
>      public void run() {
>          main.createAndShowGui();
>      }
> }
> 

Yes, this is pretty much what I was thinking.  It's pretty much the same as
the existing solution; you're just making explicit what is implicit in the
creation of the anonymous inner class.
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37