[icedtea-web] RFC: Fix handling of 0x0 applets for chromium

[Omair Majid]

On 03/03/2011 11:06 AM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com>  [2011-03-03 09:43]:
>> On 03/02/2011 08:15 PM, Dr Andrew John Hughes wrote:
>>> On 16:41 Wed 02 Mar     , Deepak Bhole wrote:
>>>> This patch fixes chromium to work with the new protocol which supplies
>>>> handle, size and url in the same message.
>>>>
>>>
>>> What new protocol?  Is this backwards compatible?
>>>
>>>> ChangeLog:
>>>>
>>>> 2011-03-02  Deepak Bhole<dbhole at redhat.com>
>>>>
>>>>      * plugin/icedteanp/IcedTeaNPPlugin.cc (get_scriptable_object):
>>>>      Supply size and url information along with handle.
>>>>
>>>> 1.0 is affected, and this patch should go there too.
>>>>
>>
>> This simply makes the chromium special-case do what is normally done
>> in ITNP_SetWindow, right? While it would be nice to share this code
>> between the methods (rather than duplicating it), it looks fine.
>>
>
> Yeah it is just one line being duplicated once. Didn't seem worth it to
> create a function for it.
>

Yeah, I noticed that. Still, we should try to avoid duplicate code, as 
it causes breakage just like this.

Cheers,
Omair