Reviewer needed - fix for Re: Strange behaviour during javaws -about part 1/2

Omair Majid omajid at redhat.com
Thu Mar 3 09:19:32 PST 2011


On 03/03/2011 03:30 AM, Jiri Vanek wrote:
> On 03/02/2011 07:41 PM, Dr Andrew John Hughes wrote:
>> On 19:33 Wed 02 Mar     , Jiri Vanek wrote:
>>> Hope that have fixed all.
>>>
>>
>> Nearly.  Please fix the superfluous bracket and add back the output in
>> Boot.java
>> but for debug only i.e. something like
>
> Fixed, i have print output to stdout, because it is information, not fault.
>> ...
>
> Bracket fixed. Damned typo:-/
>
>>
>
> extracts fixed;)
>
>
>
> diff1.diff
>
>
> diff -r 36ee2caa60d0 ChangeLog
> --- a/ChangeLog	Wed Mar 02 10:09:07 2011 -0500
> +++ b/ChangeLog	Thu Mar 03 09:26:07 2011 +0100
> @@ -1,3 +1,13 @@
> +2011-03-02  Jiri Vanek<jvanek at redhat.com>
> +
> +	* netx/net/sourceforge/jnlp/runtime/Boot.java: getAboutFile changed to
> +	return path to local about.jnlp instead to  inner-from-jar
> +	* extras/net/sourceforge/jnlp/: refactored to
> +	extras/net/sourceforge/javaws/, as/net/sourceforge/jnlp/  package
> +	must be run with all-permissions.
> +	* netx/net/sourceforge/jnlp/resources/about.jnlp: removed
> +	<all-permissions>, codebase changed to "."
> +

Please take a look at the GNU ChangeLog standards for more information 
on how to write these changelogs:
http://www.gnu.org/prep/standards/html_node/Change-Logs.html#Change-Logs

Generally, it is a good idea to explicitly name each method and/or file 
modified.

Cheers,
Omair



More information about the distro-pkg-dev mailing list