[icedtea-web] RFC: Fix handling of 0x0 applets for chromium

[Deepak Bhole]

* Deepak Bhole <dbhole at redhat.com> [2011-03-03 11:34]:
> * Omair Majid <omajid at redhat.com> [2011-03-03 11:26]:
> > >>
> > >
> > >Yeah it is just one line being duplicated once. Didn't seem worth it to
> > >create a function for it.
> > >
> > 
> > Yeah, I noticed that. Still, we should try to avoid duplicate code,
> > as it causes breakage just like this.
> > 
> 
> I don't see how a function could've avoided it. It would still have to
> be called from get_scriptable_object and would've been missed.
> 

Doh. Realized later what you meant/how a function would have prevented 
it :/

New patch with common code split off into a separate function. Okay for
1.0 and HEAD?

ChangeLog:
2011-03-03  Deepak Bhole <dbhole at redhat.com>

    * plugin/icedteanp/IcedTeaNPPlugin.cc
    (plugin_send_initialization_message): New method. Sends initialization
    information to the Java side.
    (ITNP_SetWindow): Call the new plugin_send_initialization_message
    function.
    (get_scriptable_object): Same.


Thanks,
Deepak

> Cheers,
> Deepak
> 
> > Cheers,
> > Omair
-------------- next part --------------
diff -r 5dbf0f9de599 plugin/icedteanp/IcedTeaNPPlugin.cc
--- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 02 11:50:30 2011 -0500
+++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Thu Mar 03 17:35:42 2011 -0500
@@ -220,6 +220,9 @@
 void consume_message(gchar* message);
 void start_jvm_if_needed();
 static void appletviewer_monitor(GPid pid, gint status, gpointer data);
+void plugin_send_initialization_message(char* instance, gulong handle,
+                                               int width, int height,
+                                               char* url);
 
 // Global instance counter.
 // Mutex to protect plugin_instance_counter.
@@ -768,18 +771,9 @@
       data->window_height = window->height;
 
       // Now we have everything. Send this data to the Java side
-
-      gchar* instance_msg =  g_strdup_printf ("instance %s handle %ld width %d height %d %s",
-											 data->instance_id,
-											 (gulong) data->window_handle,
-											 data->window_width,
-											 data->window_height,
-											 data->applet_tag);
-
-      plugin_send_message_to_appletviewer (instance_msg);
-
-      g_free(instance_msg);
-      instance_msg = NULL;
+      plugin_send_initialization_message(
+    		  data->instance_id, (gulong) data->window_handle,
+    		  data->window_width, data->window_height, data->applet_tag);
 
       g_mutex_unlock (data->appletviewer_mutex);
 
@@ -1834,6 +1828,22 @@
   PLUGIN_DEBUG ("plugin_send_message_to_appletviewer return\n");
 }
 
+void
+plugin_send_initialization_message(char* instance, gulong handle,
+                                   int width, int height, char* url)
+{
+  PLUGIN_DEBUG ("plugin_send_initialization_message\n");
+
+  gchar *window_message = g_strdup_printf ("instance %s handle %ld width %d height %d %s",
+                                            instance, handle, width, height, url);
+  plugin_send_message_to_appletviewer (window_message);
+  g_free (window_message);
+  window_message = NULL;
+
+  PLUGIN_DEBUG ("plugin_send_initialization_message return\n");
+}
+
+
 // Stop the appletviewer process.  When this is called the
 // appletviewer can be in any of three states: running, crashed or
 // hung.  If the appletviewer is running then sending it "shutdown"
@@ -2414,11 +2424,7 @@
         // a 0 handle
         if (!data->window_handle)
         {
-            data->window_handle = 0;
-            gchar *window_message = g_strdup_printf ("instance %s handle %d",
-                                                    id_str, 0);
-            plugin_send_message_to_appletviewer (window_message);
-            g_free (window_message);
+            plugin_send_initialization_message(data->instance_id, 0, 0, 0, data->applet_tag);
         }
 
         java_result = java_request.getAppletObjectInstance(id_str);