[icedtea-web] RFC: Fix handling of 0x0 applets for chromium

[Dr Andrew John Hughes]

On 11:05 Thu 03 Mar     , Deepak Bhole wrote:
> * Dr Andrew John Hughes <ahughes at redhat.com> [2011-03-02 20:15]:
> > On 16:41 Wed 02 Mar     , Deepak Bhole wrote:
> > > This patch fixes chromium to work with the new protocol which supplies
> > > handle, size and url in the same message.
> > > 
> > 
> > What new protocol?  Is this backwards compatible?
> > 
> 
> Previously, handle, size and url were sent in separate messages. We now
> send it in one.
> 
> This issue became a problem as soon as the above change was made (months
> ago), it just went undetected because very few sites use 0 by 0 applets.
> 

Ok, so this is a change by us and not Mozilla?

Fix is ok by me for 1.0 and HEAD.

> Cheers,
> Deepak
> 
> 
> > > ChangeLog:
> > > 
> > > 2011-03-02  Deepak Bhole <dbhole at redhat.com>
> > > 
> > >     * plugin/icedteanp/IcedTeaNPPlugin.cc (get_scriptable_object):
> > >     Supply size and url information along with handle.
> > > 
> > > 1.0 is affected, and this patch should go there too.
> > > 
> > > Cheers,
> > > Deepak
> > 
> > > diff -r 5dbf0f9de599 plugin/icedteanp/IcedTeaNPPlugin.cc
> > > --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 02 11:50:30 2011 -0500
> > > +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 02 16:08:15 2011 -0500
> > > @@ -2415,8 +2415,8 @@
> > >          if (!data->window_handle)
> > >          {
> > >              data->window_handle = 0;
> > > -            gchar *window_message = g_strdup_printf ("instance %s handle %d",
> > > -                                                    id_str, 0);
> > > +            gchar *window_message = g_strdup_printf ("instance %s handle %d width 0 height 0 %s",
> > > +                                                    id_str, 0, data->applet_tag);
> > >              plugin_send_message_to_appletviewer (window_message);
> > >              g_free (window_message);
> > >          }
> > > 
> > 
> > 
> > -- 
> > Andrew :)
> > 
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> > 
> > Support Free Java!
> > Contribute to GNU Classpath and IcedTea
> > http://www.gnu.org/software/classpath
> > http://icedtea.classpath.org
> > PGP Key: F5862A37 (https://keys.indymedia.org/)
> > Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D  0698 0713 C3ED F586 2A37