RFC: CACAO ignore all unknown options

[Xerxes Ranby]

  On 2011-03-04 01:50, Dr Andrew John Hughes wrote:
> On 01:40 Fri 04 Mar     , Xerxes Rånby wrote:
>> CACAO currently do not pass most jtreg tests because CACAO stop on any
>> unknown option, prints its usage, and then return with exit code: 1.
>>
>> This are the main reason why CACAO make check-hotspot currently fails
>> most of the tests: Test results: passed: 29; failed: 78
>>
>> For example CACAO currently fail hotspot/test/compiler/7009359 due to
>> the Unknown option: -Xbatch
>> command: main  -Xbatch -XX:+IgnoreUnrecognizedVMOptions
>> -XX:+OptimizeStringConcat
>> -XX:CompileCommand=exclude,Test7009359,mainTest7009359
>> ----------System.out:(34/1763)----------
>> Unknown option: -Xbatch
>> Usage: cacao [-options] classname [arguments]
>>                  (to run a class file)
>> ...
>> ----------System.err:(3/163)----------
>> Unknown -XX option: -XX:+IgnoreUnrecognizedVMOptions
>> Unknown -XX option: -XX:+OptimizeStringConcat
>> Unknown -XX option: -XX:CompileCommand=exclude,Test7009359,main
>> result: Failed. Unexpected exit from test [exit code: 1]
>>
>>
>> The attached patch fixes this by letting CACAO continue after it have
>> reported the Unknown option to System.err.
>>
>> Ok to push?
>>
>>
>> With this patch applied the remaining failing CACAO check-hotspot tests
>> are now reduced to a handful, here testing on a amd64 box:
>>
>> Error:  compiler/6589834/Test_ia32.java
>> FAILED: compiler/6987555/Test6987555.java
>> FAILED: compiler/6991596/Test6991596.java
>> FAILED: gc/6581734/Test6581734.java
>> FAILED: runtime/6626217/Test6626217.sh
>> FAILED: runtime/6929067/Test6929067.sh
>> FAILED: runtime/6981737/Test6981737.java
>>
>> Test results: passed: 100; failed: 6; error: 1
>>
>> Cheers
>> Xerxes
> Looks good to me.  Have you looked into upstreaming this and the similar JamVM change?
>
Commited:
http://icedtea.classpath.org/hg/icedtea6/rev/13df4d5a5bc2

I will send these two patches upstream for review.

Cheers
Xerxes