[icedtea-web] RFC: make ICEDTEAPLUGIN_DEBUG=suspend start the jvm in suspend mode

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2011-03-04 17:45]:
> Hi,
> 
> The attached patch modifies the plugin so that setting the env
> variable ICEDTEAPLUGIN_DEBUG to "suspend" when starting the plugin
> will launch the jvm in suspend mode. The behaviour with
> ICEDTEAPLUGIN_DEBUG set to any other value is unchanged.
> 
> Any thoughts or comments?
> 

Looks good to me. Please add changelog entry, then OK for head.

Cheers,
Deepak

> Cheers,
> Omair

> diff -r 5dbf0f9de599 plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 02 11:50:30 2011 -0500
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Wed Mar 02 15:28:04 2011 -0500
> @@ -235,6 +235,8 @@
>  static guint appletviewer_watch_id = -1;
>  
>  int plugin_debug = getenv ("ICEDTEAPLUGIN_DEBUG") != NULL;
> +int plugin_debug_suspend = (getenv("ICEDTEAPLUGIN_DEBUG") != NULL) &&
> +        (strcmp(getenv("ICEDTEAPLUGIN_DEBUG"), "suspend") == 0);
>  
>  pthread_cond_t cond_message_available = PTHREAD_COND_INITIALIZER;
>  
> @@ -1552,7 +1554,13 @@
>        command_line[1] = g_strdup(PLUGIN_BOOTCLASSPATH);
>        command_line[2] = g_strdup("-Xdebug");
>        command_line[3] = g_strdup("-Xnoagent");
> -      command_line[4] = g_strdup("-Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n");
> +      if (plugin_debug_suspend)
> +      {
> +          command_line[4] = g_strdup("-Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=y");
> +      } else
> +      {
> +          command_line[4] = g_strdup("-Xrunjdwp:transport=dt_socket,address=8787,server=y,suspend=n");
> +      }
>        command_line[5] = g_strdup("sun.applet.PluginMain");
>        command_line[6] = g_strdup(out_pipe_name);
>        command_line[7] = g_strdup(in_pipe_name);